Closed Bug 1719885 Opened 3 years ago Closed 3 years ago

Session restore loads a cached version of the page

Categories

(Firefox :: Session Restore, defect, P3)

Product:
Firefox
Component:
Session Restore
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 706970

People

(Reporter: u608768, Unassigned)

Details

STR

  1. Open a new tab with a document that can easily be edited (a local document works best, but https://bugzilla-dev.allizom.org/show_bug.cgi?id=1630690 also works).
  2. Close the tab.
  3. Change the document (add a comment, edit the html, etc.)
  4. Reopen the tab.
  5. Note that we've restored the initial version of the document.

It's not clear to me what we should actually be doing here, see comments below for more details.

We load the restored document by reloading the current history entry (which unfortunately happens in different places right now for fission vs. non-fission). This causes us to load the history entry with a load type of LOAD_HISTORY, which loads the version of the page that's in history, instead of the most recent version.

We can fix the problem by bypassing cache in that load (eg by using LOAD_NORMAL_BYPASS_CACHE instead), but that results in us doing a full load for each restore. It's not clear to me if we should be doing that for a few reasons:

  1. It'll likely significantly slow down session restore.
  2. I can imagine situations where users expect (and want?) the non-updated version of the page to be restored.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.