1719995 - All newly created IRC accounts can't connect

Status: VERIFIED FIXED

(Chat Core :: IRC, defect)

Description

[WIlliam Davis [:AwesomeSheep48]]

Attachment: Screen Recording 2021-07-10 at 14.42.22.mov

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

Set up my libera.chat account and pressed connect

Actual results:

It kept loading forever, saying "connecting"

Expected results:

It should have connected

Comment 1

[Martin Giger [:freaktechnik]]

Could you please show your account settings, since based on your account name this isn't connecting to irc.libera.chat.

Comment 2

[WaltS48 [:walts48]]

I can reproduce using BuildID 20210709103808 on Fedora 34 Workstation, Gnome 40 desktop.

The account properties in settings shows WaltS48@WaltS48.
Using Thunderbird 78.11.0 the account setting is WaltS48(at)irc.libera.chat.

Comment 3

[Martin Giger [:freaktechnik]]

Right, so this is then most likely completely unrelated to libera, but instead an issue with IRC accounts. I assume these are newly created accounts?

Comment 4

[WIlliam Davis [:AwesomeSheep48]]

My account was created on May 29th

Comment 5

[WIlliam Davis [:AwesomeSheep48]]

Attachment: Screen Shot 2021-07-11 at 11.40.58.png

Comment 6

[Martin Giger [:freaktechnik]]

(In reply to WIlliam Davis (@awesomesheep48:matrix.org) from comment #4)

My account was created on May 29th

What I'm after is what version you created it with (as in, is this from a beta profile) and if it worked previously.

Comment 7

[WIlliam Davis [:AwesomeSheep48]]

Attachment: Screen Shot 2021-07-11 at 11.40.17.png

Comment 8

[WIlliam Davis [:AwesomeSheep48]]

(In reply to Martin Giger [:freaktechnik] from comment #6)

(In reply to WIlliam Davis (@awesomesheep48:matrix.org) from comment #4)

My account was created on May 29th

What I'm after is what version you created it with (as in, is this from a beta profile) and if it worked previously.

I created it on https://web.libera.chat, and I'm pretty sure I have used it in thunderbird before, but I cannot really remember.

Comment 9

[Martin Giger [:freaktechnik]]

(In reply to WIlliam Davis (@awesomesheep48:matrix.org) from comment #8)

I created it on https://web.libera.chat, and I'm pretty sure I have used it in thunderbird before, but I cannot really remember.

Ah sorry, by account I don't refer to the libera registration but to the account you created in thunderbird in order to connect to libera.

Comment 10

[WaltS48 [:walts48]]

(In reply to Martin Giger [:freaktechnik] from comment #3)

Right, so this is then most likely completely unrelated to libera, but instead an issue with IRC accounts. I assume these are newly created accounts?

Yes, I thought I had it setup in my Daily on Linux, but I didn't, so I created the account.
Also see the same in my Daily on Windows 10.

Comment 11

[WIlliam Davis [:AwesomeSheep48]]

(In reply to Martin Giger [:freaktechnik] from comment #9)

(In reply to WIlliam Davis (@awesomesheep48:matrix.org) from comment #8)

I created it on https://web.libera.chat, and I'm pretty sure I have used it in thunderbird before, but I cannot really remember.

Ah sorry, by account I don't refer to the libera registration but to the account you created in thunderbird in order to connect to libera.

Oh, then yeah, it is a newly created account using Daily.

Comment 12

[Martin Giger [:freaktechnik]]

Attachment: Bug 1719995 - Properly handle username split without separator for IRC. r=clokep

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c31c6cefa39e
Properly handle username split without separator for IRC. r=clokep

Comment 14

[Patrick Cloke [:clokep]]

We'll want to uplift this, I assume?

Also -- to the original reporter. It looks like you'll need to delete your account and re-create it, I don't think there's a way to recover from the incorrect account information in this case.

Comment 15

[Martin Giger [:freaktechnik]]

Agreed with both. Given the communication around uplifts recently I'll wait a week to request it though.

Comment 16

[WaltS48 [:walts48]]

I just successfully created my Libera chat account and joined the #thunderd channel in 92.0a1 on Linux.

Comment 17

[Martin Giger [:freaktechnik]]

Comment on attachment 9230690 [details]
Bug 1719995 - Properly handle username split without separator for IRC. r=clokep

[Approval Request Comment]
Regression caused by (bug #): bug 1699099
User impact if declined: New IRC accounts will have corrupted username and server in many common cases
Testing completed (on c-c, etc.): Tested account creation manually (see comment before this)
Risk to taking this patch (and alternatives if risky): Risk should be fairly low, since all this does is handle invalid input differently (arguably correctly). If this isn't taken we would want to revert the bug that introduced the regression instead, which is much more change (and would need manual massaging to not break matrix at the very least).

Comment 18

[Wayne Mery (:wsmwk)]

Comment on attachment 9230690 [details]
Bug 1719995 - Properly handle username split without separator for IRC. r=clokep

[Triage Comment]
Approved for beta (and I see it has a test - thanks)

Comment 19

[Rob Lemley [:rjl]]

Thunderbird 91.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/9879e7ef2a9b