1720232 - SQLite calls could timeout in starvation situations.

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P1)

Description

[Robert Relyea]

Attachment: nss-3.67-fix-sdb-timeout.patch

Some of our servers could cause random failures when trying to generate many key pairs from multiple threads. This is caused because some threads would starve long enough for them to give up on getting a begin transaction on sqlite. sqlite only allows one transaction at a time.

Also, there were some bugs in error handling of the broken transaction case where NSS would try to cancel a transation after the begin failed (most cases were correct, but one case in particular was problematic).

This patch is for reference only, and I'll definitely attach this as a phabricator patch.

Comment 1

[Benjamin Beurdouche [:beurdouche]]

Bob, can you please set severity for this? Thank you! : )

Comment 2

[Robert Relyea]

Attachment: Bug 1720232 SQLite calls could timeout in starvation situations.

Some of our servers could cause random failures when trying to generate many key pairs from multiple threads. This is caused because some threads would starve long enough for them to give up on getting a begin transaction on sqlite. sqlite only allows one transaction at a time.

Also, there were some bugs in error handling of the broken transaction case where NSS would try to cancel a transation after the begin failed (most cases were correct, but one case in particular was problematic).

Comment 3

[Benjamin Beurdouche [:beurdouche]]

https://hg.mozilla.org/projects/nss/rev/b54b0d41e51bc302c58721c08525f85fd5e8d0f9