1720308 - `./mach ide vscode` doesn't find Visual Studio Code installed (as a snap) via the Ubuntu software manager

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Jonathan Kew [:jfkthame]]

I set up a new machine with Ubuntu 20.04LTS, and installed Visual Studio Code via the Ubuntu Software manager. This installed it as a snap package, with the executable at /snap/bin/code.

/snap/bin is in my $PATH, so I was quite surprised when ./mach ide vscode reported that it couldn't find the vscode binary, and I had to enter the path manually each time.

On looking into this, it turns out that it doesn't use the current $PATH but looks in a few specific locations hardcoded in the python script.

To make things more convenient for people who (like me) install VSCode in the "obvious" way via the Ubuntu UI, I'd suggest we should add /snap/bin/code to the known locations that mach checks.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1720308 - Support VSCode installed as a snap package on Linux. r=#firefox-build-system-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc8a3fd81096
Support VSCode installed as a snap package on Linux. r=firefox-build-system-reviewers,nalexander

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/dc8a3fd81096