Closed Bug 1720362 Opened 1 year ago Closed 1 year ago

Remove the last MOZ_GECKO_PROFILER ifdefs in ipc code

Categories

(Core :: Gecko Profiler, task, P3)

task

Tracking

()

RESOLVED FIXED
92 Branch
Tracking Status
firefox92 --- fixed

People

(Reporter: florian, Assigned: florian)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

profiler_set_process_name needs to always be declared to remove the ifdef at dom/ipc/ContentChild.cpp#848.

dom/ipc/ContentParent.cpp uses ReceiveShutdownProfile from nsIProfiler.idl which only exists when the profiler is built, but that function only calls another function, that could be called directly.

ipc/glue/GeckoChildProcessHost.cpp usesGetProfilerEnvVarsForChildProcess`, that needs to be always declared.

profiler_{un,}register_page are called from dom/ipc/WindowGlobalChild.cpp, they need to be always declared.

Severity: -- → N/A
Priority: -- → P3
Pushed by fqueze@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/90be9264fbdc
Remove the last MOZ_GECKO_PROFILER ifdefs in ipc code, r=gerald.
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.