Closed Bug 1720372 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 29651 - [VirtualKeyboard] Add Secure Context to VK interface.

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox92 fixed)

Status:
RESOLVED FIXED
Milestone:
92 Branch
Tracking Flags:
Tracking Status
firefox92 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29651 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29651
Details from upstream follow.

b'Anupam Snigdha <snianu@microsoft.com>' wrote:

[VirtualKeyboard] Add Secure Context to VK interface.

Added SecureContext to VK interface as we don't want to show/hide VK
when the document isn't the active document and hasn't been
authenticated. Some tests that used to run on insecure context were
changed to now use secure context instead. Using secure context also
led to removal of some tests where we were manually injecting VK
events to the browser. The embedded test server usage causes the
input method initialized in the RWHVA to use the real input method
instead of the mock implementation.
WPT tests in crrev.com/c/2993938 cover those cases.
Spec: https://github.com/w3c/editing/blob/gh-pages/docs/virtualkeyboard/index.html

Bug: 856269

Change-Id: Ie4fa4c50a08e8d439b985e62beea4d9aa57f3e26

Reviewed-on: https://chromium-review.googlesource.com/3003699
WPT-Export-Revision: 3c0c855d7afaa2183910577582df2154a31f8596

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 4 subtests

Status Summary

Firefox

OK : 1
FAIL: 4

Chrome

OK : 1
FAIL: 4

Safari

OK : 1
FAIL: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/virtual-keyboard/virtual-keyboard-type.https.html
navigator.virtualKeyboard is an object: FAIL (Chrome: FAIL, Safari: FAIL)
navigator.virtualKeyboard has type VirtualKeyboard: FAIL (Chrome: FAIL, Safari: FAIL)
navigator.virtualKeyboard.show instanceof Function: FAIL (Chrome: FAIL, Safari: FAIL)
navigator.virtualKeyboard.hide instanceof Function: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/aab897b961ff [wpt PR 29651] - [VirtualKeyboard] Add Secure Context to VK interface., a=testonly https://hg.mozilla.org/integration/autoland/rev/e935afa24e76 [wpt PR 29651] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ffc9f3b929f1 [wpt PR 29651] - [VirtualKeyboard] Add Secure Context to VK interface., a=testonly https://hg.mozilla.org/integration/autoland/rev/3d225dca28d3 [wpt PR 29651] - Update wpt metadata, a=testonly
You need to log in before you can comment on or make changes to this bug.