1720390 - Update login.live.com match to .live.com

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P1)

Description

[Mike Kaply [:mkaply]]

In bug 1695693 we added window sso support and we add cookies for login.live.com

Microsoft has said we should actually match .live.com as there might be other subdomains.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

I think this looks like a P2 - :mkaply, could you correct that if you're not immediately working on this?

Comment 2

[Mike Kaply [:mkaply]]

Sure, I am going to work on this.

Hoping to get it in beta this week.

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Bug 1720390 - Match any .live.com domain for Windows single sign on. r?nhnt11

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/38fc949060d9
Match any .live.com domain for Windows single sign on. r=nhnt11,necko-reviewers,kershaw

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/38fc949060d9

Comment 6

[Mike Kaply [:mkaply]]

Comment on attachment 9232163 [details]
Bug 1720390 - Match any .live.com domain for Windows single sign on. r?nhnt11

Beta/Release Uplift Approval Request

• User impact if declined: It's possible some sites won't work with Windows SSO. Microsoft requested this change.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just changes the string query for the domain for this feature.
  91 is the first release that has this feature, so want to get it right.
• String changes made/needed:

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9232163 [details]
Bug 1720390 - Match any .live.com domain for Windows single sign on. r?nhnt11

Low risk, approved for 91 beta 6, thanks.

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/ea1a2bf513be