Closed Bug 1720398 Opened 1 year ago Closed 11 months ago

[wpt-sync] Sync PR 29656 - [TableNG] Fix restricted block-size child behaviour.

Categories

(Core :: Layout: Tables, task, P4)

task

Tracking

()

RESOLVED FIXED
92 Branch
Tracking Status
firefox92 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29656 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29656
Details from upstream follow.

b'Ian Kilpatrick <ikilpatrick@chromium.org>' wrote:

[TableNG] Fix restricted block-size child behaviour.

The restricted block-size behaviour effectively sizing some children
at their min-block-size for the purposes of measuring, but also layout.

Previously we only applied this behaviour when measuring a child.

However for the example in: crbug.com/1227868

  • we'd measure the item at 120px.
  • then layout at 200px.

This was incorrect. The legacy implementation never triggered the 2nd
layout for this case to the existing code within the
NGBlockLayoutAlgorithm just "worked".

What we really need to do is apply this "min-size" behaviour if the
%-block-size child can't resolve. This ensures that its height is
consistent between the measure, and layout passes.

This also stops considering a \<td style="height: 100%"> as "restricted".
This was necessary for this change, but also matches what EdgeHTML
did previously.

Bug: 1227868
Change-Id: I3eaa60dec8409367bee20eebd5e155f2b6ec70db

Reviewed-on: https://chromium-review.googlesource.com/3025024
WPT-Export-Revision: d719b42d1c2c1907244a83367eaf50821075efeb

Component: web-platform-tests → Layout: Tables
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-tables/height-distribution/percentage-sizing-of-table-cell-007.html: FAIL (Chrome: FAIL, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/af713fd12372
[wpt PR 29656] - [TableNG] Fix restricted block-size child behaviour., a=testonly
https://hg.mozilla.org/integration/autoland/rev/5761d24ca1e7
[wpt PR 29656] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8be1fae2d9a2
[wpt PR 29656] - [TableNG] Fix restricted block-size child behaviour., a=testonly
https://hg.mozilla.org/integration/autoland/rev/cb026d1d8df4
[wpt PR 29656] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.