1720410 - Mitigation: Remove ServiceWorker registrations after multiple navigation faults, potentially clearing origin/group storage

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, task, P2)

Description

[Andrew Sutherland [:asuth] (he/him)]

As a continuation of mitigations planned in Bug 1503072 as discussed in Bug 1503072 comment 20, we want to:

1. Automatically remove ServiceWorker registrations after multiple faults.
2. Consider clearing the origin/group QuotaManager storage.

For this bug we may just want to only deal with the registration removal and spin off the 2nd item to an additional follow-up. I'm group them together now for simplicity.

Comment 1

[Eden Chuang[:edenchuang]]

Attachment: Bug 1720410 - Unregister SW when reach navigation fault threshold. r=#dom-workers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cacb5906a46c
Unregister SW when reach navigation fault threshold. r=dom-worker-reviewers,asuth

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/cacb5906a46c

Comment 4

[Eden Chuang[:edenchuang]]

Comment on attachment 9231147 [details]
Bug 1720410 - Unregister SW when reach navigation fault threshold. r=#dom-workers

Beta/Release Uplift Approval Request

• User impact if declined: Users will suffer from bad loading performance caused by a broken service worker. Every navigation under the controlled scope would get intercepted and then reset to normal network fetching caused by the broken service worker.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It is a low risk since it just unregisters the broken service worker directly when it meets the navigation fault threshold. By unregistering the broken service worker, it has a chance to re-install a fixed service worker.
• String changes made/needed: No

Comment 5

[Pascal Chevrel:pascalc (PTO until Sept 2)]

Comment on attachment 9231147 [details]
Bug 1720410 - Unregister SW when reach navigation fault threshold. r=#dom-workers

Approved for 91 beta 9, thanks.

Comment 6

[Pascal Chevrel:pascalc (PTO until Sept 2)]

https://hg.mozilla.org/releases/mozilla-beta/rev/15847bf81c6c