Closed Bug 1720421 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29657 - [LayoutNG] OOF static position with conflicting direction

Categories

(Core :: Layout: Positioned, task, P4)

Product:
Core
Component:
Layout: Positioned
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
92 Branch
Tracking Flags:
Tracking Status
firefox92 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29657 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29657
Details from upstream follow.

b'Alison Maher <almaher@microsoft.com>' wrote:

[LayoutNG] OOF static position with conflicting direction

We were always using the containing block's writing mode when
converting the static position because we want the offset to be
relative to the CB. However, this resulted in an incorrect offset
when the multicol had a different direction. Instead of always
using the CB's writing mode when converting the static position, use
the current fragment's writing mode.

The added tests are based on their non-multicol counterparts. Some
of the tests passed previously if there was no writing mode mismatch.

Bug: 1228746
Change-Id: I2027ccd7c384a75f54d8dc5833de775f3ab7e58c
Reviewed-on: https://chromium-review.googlesource.com/3025848
WPT-Export-Revision: c23dd5c924188b089e6fe84b3e9b0ebf0427b13b

Component: web-platform-tests → Layout: Positioned
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 8 tests

Status Summary

Firefox

FAIL: 8

Chrome

PASS: 2
FAIL: 6

Safari

FAIL: 8

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-position/static-position/multicol/vlr-ltr-ltr-in-multicol.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-position/static-position/multicol/vlr-ltr-rtl-in-multicol.tentative.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-position/static-position/multicol/vlr-rtl-ltr-in-multicol.tentative.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-position/static-position/multicol/vlr-rtl-rtl-in-multicol.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-position/static-position/multicol/vrl-ltr-ltr-in-multicol.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-position/static-position/multicol/vrl-ltr-rtl-in-multicol.tentative.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-position/static-position/multicol/vrl-rtl-ltr-in-multicol.tentative.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-position/static-position/multicol/vrl-rtl-rtl-in-multicol.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2b37d58c1e56 [wpt PR 29657] - [LayoutNG] OOF static position with conflicting direction, a=testonly https://hg.mozilla.org/integration/autoland/rev/d88fc7ab0f6d [wpt PR 29657] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0a976640b48a [wpt PR 29657] - [LayoutNG] OOF static position with conflicting direction, a=testonly https://hg.mozilla.org/integration/autoland/rev/1bf9143c5b3b [wpt PR 29657] - Update wpt metadata, a=testonly
You need to log in before you can comment on or make changes to this bug.