Fix -Wunused-but-set-variable warnings in dom/media
Categories
(Core :: Audio/Video, defect, P3)
Tracking
()
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(1 file)
clang and gcc report the following -Wunsed-but-set-variable warnings in dom/media:
dom/media/gmp/GMPSharedMemManager.cpp:54:10: warning: variable 'total' set but not used [-Wunused-but-set-variable]
dom/media/gtest/TestMP3Demuxer.cpp:423:13: warning: variable 'numSamples' set but not used [-Wunused-but-set-variable]
GMPSharedMemManager.cpp updates local variable total
, but never reads it so we can remove it.
TestMP3Demuxer.cpp updates local variable numSamples
, but the EXPECT test checks that use numSamples
are commented out. I don't know how to address the commented-out checks' issues, but testing that numSamples is non-negative seems a safe assumption (and a way to fix the -Wunused-but-set-variable warning).
Assignee | ||
Comment 1•3 years ago
|
||
dom/media/gmp/GMPSharedMemManager.cpp:54:10: warning: variable 'total' set but not used [-Wunused-but-set-variable]
dom/media/gtest/TestMP3Demuxer.cpp:423:13: warning: variable 'numSamples' set but not used [-Wunused-but-set-variable]
GMPSharedMemManager.cpp updates local variable total
, but never reads it so we can remove it.
TestMP3Demuxer.cpp updates local variable numSamples
, but the EXPECT test checks that use numSamples
are commented out. I don't know how to address the commented-out checks' issues, but testing that numSamples is non-negative seems a safe assumption (and a way to fix the -Wunused-but-set-variable warning).
Pushed by cpeterson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cdd6ccd2d242 Fix -Wunsed-but-set-variable warnings in dom/media. r=kinetik
Comment 3•3 years ago
|
||
bugherder |
Description
•