1720499 - Assertion failure: clone->Equals(this), at /Users/niklasgogge/workspace/mozilla-central/netwerk/protocol/http/nsHttpConnectionInfo.cpp:316

Status: RESOLVED FIXED

(Core :: Networking, defect, P2)

Description

[Kershaw Chang [:kershaw]]

The stack below is copied from bug 1676024 #c18.

0:59.80 pid:64306 Assertion failure: clone->Equals(this), at /Users/niklasgogge/workspace/mozilla-central/netwerk/protocol/http/nsHttpConnectionInfo.cpp:316
 0:59.80 pid:64306 #01: mozilla::net::nsHttpConnectionInfo::Clone() const [/Users/niklasgogge/workspace/mozilla-central/netwerk/protocol/http/nsHttpConnectionInfo.cpp:316]
 0:59.80 pid:64306 #02: mozilla::net::nsHttpConnectionMgr::ProcessPendingQ(mozilla::net::nsHttpConnectionInfo*) [/Users/niklasgogge/workspace/mozilla-central/netwerk/protocol/http/nsHttpConnectionMgr.cpp:559]
 0:59.80 pid:64306 #03: mozilla::net::ConnectionEntry::CloseAllDnsAndConnectSockets() [/Users/niklasgogge/workspace/mozilla-central/netwerk/protocol/http/ConnectionEntry.cpp:99]
 0:59.80 pid:64306 #04: mozilla::net::nsHttpConnectionMgr::AbortAndCloseAllConnections(int, mozilla::net::ARefBase*) [/Users/niklasgogge/workspace/mozilla-central/netwerk/protocol/http/nsHttpConnectionMgr.cpp:1920]
 0:59.80 pid:64306 #05: mozilla::net::nsHttpConnectionMgr::OnMsgShutdown(int, mozilla::net::ARefBase*) [/Users/niklasgogge/workspace/mozilla-central/netwerk/protocol/http/nsHttpConnectionMgr.cpp:1937]
 0:59.80 pid:64306 #06: mozilla::net::ConnEvent::Run() [/Users/niklasgogge/workspace/mozilla-central/netwerk/protocol/http/nsHttpConnectionMgr.cpp:204]
 0:59.80 pid:64306 #07: nsThread::ProcessNextEvent(bool, bool*) [/Users/niklasgogge/workspace/mozilla-central/xpcom/threads/nsThread.cpp:0]
 0:59.80 pid:64306 #08: NS_ProcessNextEvent(nsIThread*, bool) [/Users/niklasgogge/workspace/mozilla-central/xpcom/threads/nsThreadUtils.cpp:548]
 0:59.80 pid:64306 #09: mozilla::net::nsSocketTransportService::Run() [/Users/niklasgogge/workspace/mozilla-central/netwerk/base/nsSocketTransportService2.cpp:1205]

Comment 1

[Kershaw Chang [:kershaw]]

The problem here is that nsProxyInfo::mResolveFlags is modified when the connection info is still referenced by a connection entry.
When this happens, nsHttpConnection::mUsingConnect could be changed to true, so we hit this assertion.
To fix this issue, I think we should not allow to modify nsProxyInfo after it's created.

Comment 2

[Kershaw Chang [:kershaw]]

Attachment: Bug 1720499 - Don't allow to modify nsProxyInfo::mResolveFlags, r=bwc

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/efaefc2f3342
Don't allow to modify nsProxyInfo::mResolveFlags, r=ngogge

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/efaefc2f3342