1720507 - [UK][tesco.com] CC capture doorhanger is not displayed due to fieldset element

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P2)

Description

[Tim Giles [:tgiles]]

+++ This bug was initially created as a clone of Bug #1687679 +++

Affected Versions:

• All latest Firefox versions using force enable (Nightly 86, Beta RC 85.0, Release 84.0.2)

Tested on:

• MacOS 10.15
• Windows 10 x64

Prerequisites:

• browser.search.region UK
• extensions.formautofill.supportedCountries UK
• download latest Firefox Nightly with region locale (switch extensions.formautofill.available to "on" for testing non-Nightly builds)

Steps to Reproduce:

1. Launch Firefox
2. Go to and reach the payment form Tesco.com
3. Fill in manually all the fields and submit the form - observe Bug 2

Expected Results:
2. Credit Card Save doorhanger should be displayed after form submission

Actual Results:
2. Bug 2: The Credit Card Save doorhanger is not displayed after the form was submitted

Notes:

• Severity: S3 severity, the autofilled exp month value should correctly detect the expected format
• Reproducible on Chrome?: No
• Regression-range: reproducible on all latest versions, this site was never tested before, can look for regression-range if need be

Comment 1

[Tim Giles [:tgiles]]

Attachment: Bug 1720507: Fix CC capture panel not appearing due to fieldset element. r=dimi,sfoster

When form autofill determines which extra fields were not autofilled, there is a chance that the filtered element will not have a value property (in our case, fieldset elements).
By ensuring we return an undefined instead of accessing a property that doesn't exist, we can ensure the rest of the credit card show panel flow works as expected

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/643fbdd428f3
Fix CC capture panel not appearing due to fieldset element. r=dimi,sfoster

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/643fbdd428f3

Comment 7

[Timea Cernea [:tbabos][inactive]]

Verified-fixed on the latest Firefox Nightly 95.0a1 (2021-11-01) and Firefox Release 93.0 on MacOS 10.15 and Windows 10.
The Save doorhanger is now displayed with the correct field values and does Save the new CC entry.