Closed Bug 1720524 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29661 - [EyeDropper API] Update implementation to match explainer.

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox92 fixed)

RESOLVED FIXED
92 Branch
Tracking Status
firefox92 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29661 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29661
Details from upstream follow.

b'Ionel Popescu <iopopesc@microsoft.com>' wrote:

[EyeDropper API] Update implementation to match explainer.

Explainer:
https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/EyeDropper/explainer.md

I2P: https://groups.google.com/a/chromium.org/g/blink-dev/c/cPTMI1i6d7I/

The explainer was updated to address the tag review:

  • moved to a promise based design (EyeDropper.open() returns a
    Promise\<ColorSelectionResult>)
  • renamed the selected color property to sRGBHex to make it clear that
    the color is a string and it is in sRGB (this allows room for future
    properties to be added)

For now a manual test has been added, more test coverage is going to be
added in follow-up CLs.

Bug: 897309
Change-Id: Ib3631b94ff43cd59ba1640f0c295e233f058383a

Reviewed-on: https://chromium-review.googlesource.com/3027321
WPT-Export-Revision: 78f0e055d6d48290bda0f855e77bde38293acbe5

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/beeb3d2d01b5 [wpt PR 29661] - [EyeDropper API] Update implementation to match explainer., a=testonly
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dfe30347ab9f [wpt PR 29661] - [EyeDropper API] Update implementation to match explainer., a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.