1720567 - FF 90.0: Pocket tag can no longer be added with keyboard

Status: VERIFIED FIXED

(Firefox :: Pocket, enhancement)

Description

[Luke Williams]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:90.0) Gecko/20100101 Firefox/90.0

Steps to reproduce:

1. Click the Save to Pocket button in FF
2. Click Tag box
3. Type a tag
4. Try to Save it with the keyboard (by typing Enter, or Tab, or Right arrow...)

Actual results:

Save appears to be impossible via keyboard

Expected results:

It should be trivial to save with the keyboard. Ideally, least clicks:

1. Save to Pocket is clicked
2. Tags box is auto-highlighted (would be my preference though I could understand if that's not universal... if Esc is pressed, focus can revert to wherever it was, which is the same as the current behavior)
3. After a tag is typed, Tab would add the tag but not submit the control. But Enter would add the tag and submit the control.

That way, adding to pocket + saving a tag would take the minimum effort: click Save, type tag name, press enter.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Pocket' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Petruta Horea [:phorea]]

Reproduced in latest Nightly 92.0a1, so confirming.

Comment 3

[Scott [:thecount] Downe]

I think there are two things going on here.

1. There was a regression from bug 1709402 that caused the enter key to no longer submit tags.
2. We could improve the general usage of the tag input, example, possibly including auto highlight.

I can see what can be done for the first issue, and make enter input tags again, and make it work close like it did before in this bug.

I also think I can pass on other improvements like auto highlight or other improvements to design for future consideration.

Comment 4

[Scott [:thecount] Downe]

[Tracking Requested - why for this release]: it's a 1 liner, so might be worth considering for uplift into 91.

Comment 5

[Scott [:thecount] Downe]

Attachment: Bug 1720567 - Pocket panel, fixing enter key for tag input.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a631875c476c
Pocket panel, fixing enter key for tag input. r=gvn

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/a631875c476c

Comment 8

[Scott [:thecount] Downe]

Comment on attachment 9231457 [details]
Bug 1720567 - Pocket panel, fixing enter key for tag input.

Beta/Release Uplift Approval Request

• User impact if declined: UX issues around keyboard navigation on Pocket panel tagging.

• Is this code covered by automated tests?: Yes

• Has the fix been verified in Nightly?: No

• Needs manual test from QE?: Yes

• If yes, steps to reproduce: Steps to reproduce:

  Click the Save to Pocket button in FF
  Click Tag box
  Type a tag
  Try to Save it with the keyboard (by typing Enter, or Tab, or Right arrow...)

• List of other uplifts needed: None

• Risk to taking this patch: Low

• Why is the change risky/not risky? (and alternatives if risky): It's a super small change.

• String changes made/needed: None

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9231457 [details]
Bug 1720567 - Pocket panel, fixing enter key for tag input.

Approved for 91 beta 7, thanks.

Comment 10

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/a126751f3d9a

Comment 11

[Cristian Baica [:cbaica], Release Desktop QA]

I've managed to reproduce the issue using an Fx92.0a1 build.
The issue is verified fixed using Fx91.0b7 and latest Fx92.0a1 on Windows 10 and Ubuntu 20.04. The pocket with tag can be successfully saved by hitting enter on the keyboard.