1720609 - Remove or update probes expiring in Firefox 93: slow_script_warning.shown#shown - browser_parent_process_hang_telemetry.js will fail when Gecko version number gets increased to 93 on 2021-08-09

Status: VERIFIED FIXED

(Core :: Performance, task, P2)

Description

[telemetry-probes]

The following Firefox probes will expire in the next major Firefox nightly release: version 93 [1].

slow_script_warning.shown#shown

What to do about this:

1. If one, some, or all of the metrics are no longer needed, please remove them from their definitions files (Histograms.json, Scalars.yaml, Events.yaml).
2. If one, some, or all of the metrics are still required, please submit a Data Collection Review [2] and patch to extend their expiry. There is a shorter form for data collection renewal [3].

If you have any problems, please ask for help on the #data-help Slack channel or the #telemetry Matrix room at https://chat.mozilla.org/#/room/#telemetry:mozilla.org. We'll give you a hand.

Your Friendly, Neighborhood Telemetry Team

[1] https://wiki.mozilla.org/Release_Management/Calendar
[2] https://wiki.mozilla.org/Firefox/Data_Collection
[3] https://github.com/mozilla/data-review/blob/master/renewal_request.md

This is an automated message sent from probe-scraper. See https://github.com/mozilla/probe-scraper for details.

Comment 1

[Chris Peterson [:cpeterson]]

Moving to the Performance component.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to p2 as the bug is tracked by a release manager for the current nightly.
See What Do You Triage for more information

Comment 3

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1720609 - Renew slow_script_warning.shown probe r?Gijs

I don't see why we would want this to go away. The slow script warning is going
to continue to exist, and I think it's unlikely that we won't ever make changes
to its logic, so it makes sense to continue monitoring it.

Comment 4

[Alex Thayer [:alexical] (she/her)]

Comment on attachment 9234304 [details]
Bug 1720609 - Renew slow_script_warning.shown probe r?Gijs

Request for Data Collection Renewal

** This form is for the renewal of an existing, reviewed data collection.**

** All questions are mandatory.
You must receive Data Review from a
Data Steward
on a filled-out Request before shipping your renewed data collection.**

1. Provide a link to the initial Data Collection Review Request for this collection.
   https://bugzilla.mozilla.org/show_bug.cgi?id=1652613#c3

2. When will this collection now expire?
   never

3. Why was the initial period of collection insufficient?
   We will continue to show the slow script warning indefinitely, and we have made changes to its logic in the past and I don't see the current logic as final, so it makes sense that we will want to continue being able to monitor it for changes indefinitely.

Comment 5

[Chris H-C :chutten]

Attachment: data collection renewal request

In future please attach data collection reviews to bugs.

Comment 6

[Chris H-C :chutten]

Comment on attachment 9234903 [details]
data collection renewal request

Making data collections permanent requires the use of the full Data Collection Review as we need to collect more information for permanent collections (like the individual responsible for it).

Comment 7

[Alex Thayer [:alexical] (she/her)]

Attachment: Request for data collection review

Comment 8

[Chris H-C :chutten]

Comment on attachment 9234951 [details]
Request for data collection review

Nicole's on PTO, so I'll step in and stunt for her.

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Doug Thayer is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a8aafd5b46c
Renew slow_script_warning.shown probe r=Gijs

Comment 10

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/7a8aafd5b46c