1720666 - 46.85 - 3.19% google-slides FirstVisualChange / google-slides loadtime + 26 more (Linux, OSX, Windows) regression on Tue July 13 2021

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Florin Strugariu [:Bebe]]

Perfherder has detected a browsertime performance regression from push 28c7b58df8e4d6f8cd4914b197031db988dc76ea. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
47%	google-slides	FirstVisualChange	windows10-64-shippable-qr	warm webrender	248.33 -> 364.67
35%	google-slides	LastVisualChange	linux1804-64-shippable-qr	cold webrender	3,686.67 -> 4,986.67
35%	google-slides	SpeedIndex	windows10-64-shippable-qr	warm webrender	571.75 -> 769.33
33%	google-slides	SpeedIndex	windows10-64-shippable-qr	warm webrender	575.42 -> 765.33
32%	google-slides	PerceptualSpeedIndex	windows10-64-shippable-qr	warm webrender	587.25 -> 777.83
31%	google-slides	LastVisualChange	windows10-64-shippable-qr	warm webrender	2,154.33 -> 2,816.25
30%	google-slides	FirstVisualChange	windows10-64-shippable-qr	cold webrender	446.92 -> 580.00
28%	google-slides	ContentfulSpeedIndex	windows10-64-shippable-qr	warm webrender	812.08 -> 1,043.17
26%	google-slides	PerceptualSpeedIndex	windows10-64-shippable-qr	cold webrender	888.25 -> 1,123.50
26%	google-slides	SpeedIndex	windows10-64-shippable-qr	cold webrender	846.00 -> 1,064.83
...	...	...	...	...	...
9%	google-slides	dcf	windows10-64-shippable-qr	cold webrender	1,131.73 -> 1,236.76
9%	google-slides	ContentfulSpeedIndex	macosx1015-64-shippable-qr	cold webrender	1,342.92 -> 1,466.58
8%	google-slides	SpeedIndex	macosx1015-64-shippable-qr	cold webrender	1,102.33 -> 1,194.08
7%	google-slides	loadtime	windows10-64-shippable-qr	warm webrender	1,074.06 -> 1,147.62
3%	google-slides	loadtime	linux1804-64-shippable-qr	warm webrender	1,193.62 -> 1,231.75

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
4%	google-slides	dcf	linux1804-64-shippable-qr	warm webrender	852.00 -> 821.92

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1696842

Comment 2

[Glenn Watson [:gw]]

I won't have time to investigate this week, so I've asked for the patch to be backed out for now - it's only a very small patch so it should be easy to back out and re-land once I have investigated the regression.

Comment 3

[Florin Strugariu [:Bebe]]

== Change summary for alert #30600 (as of Tue, 20 Jul 2021 04:12:00 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
48%	google-slides	LastVisualChange	macosx1014-64-shippable-qr	warm webrender	5,730.00 -> 2,956.67
46%	google-slides	LastVisualChange	macosx1014-64-shippable-qr	cold webrender	12,313.33 -> 6,670.00
41%	google-slides	ContentfulSpeedIndex	macosx1014-64-shippable-qr	warm webrender	1,653.08 -> 976.67
39%	google-slides	PerceptualSpeedIndex	macosx1014-64-shippable-qr	warm webrender	1,332.08 -> 811.50
38%	google-slides	SpeedIndex	macosx1014-64-shippable-qr	warm webrender	1,286.75 -> 793.50
...	...	...	...	...	...
7%	google-slides	loadtime	windows10-64-shippable-qr	warm webrender	1,148.69 -> 1,069.04

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=30600

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Closing this as fixed by backout.