1720696 - Crash in [@ mozilla::a11y::sdnAccessible::QueryInterface]

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

[Tracking Requested - why for this release]: Top crasher.

200 crash reports from 64 installations for Firefox 90.0 on all Windows versions, both content and parent crashes

Crash report: https://crash-stats.mozilla.org/report/index/70aa2e99-b9a8-43ae-8a3a-2b72a0210715

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 9 frames of crashing thread:

0 xul.dll mozilla::a11y::sdnAccessible::QueryInterface accessible/windows/sdn/sdnAccessible.cpp:55
1 xul.dll mozilla::detail::RunnableFunction<`lambda at /builds/worker/checkouts/gecko/ipc/mscom/MainThreadHandoff.cpp:612:22'>::Run xpcom/threads/nsThreadUtils.h:534
2 xul.dll static mozilla::mscom::MainThreadInvoker::MainThreadAPC ipc/mscom/MainThreadInvoker.cpp:172
3 ntdll.dll RtlDispatchAPC 
4 ntdll.dll RtlpModuleEnumeratorCallback 
5 ntdll.dll RtlDispatchAPC 
6 ntdll.dll KiUserApcDispatch 
7 ntdll.dll RtlpModuleEnumeratorCallback 
8 ntdll.dll NtTestAlert 

Comment 1

[Julien Cristau [:jcristau]]

I'm concerned by the number of crashes since the start of the 90 rollout, so for now I'm treating this as a blocker to re-enabling updates.

Morgan, since Jamie is out can you take a look?

Comment 2

[Julien Cristau [:jcristau]]

[woops, wrong flag]

Comment 3

[Morgan Reschenberg [:morgan]]

Investigating :) ni'ing eitan too, since this is time sensitive

Comment 4

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1720696: Ensure mMsaa is null when creating an sdnAccessible with an nsINode r?eeejay

Comment 5

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1720696: Only fetch mMsaa from non-null AccessibleWraps r?eeejay

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f5962c50e5d
Only fetch mMsaa from non-null AccessibleWraps r=eeejay

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5f5962c50e5d

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 9231400 [details]
Bug 1720696: Only fetch mMsaa from non-null AccessibleWraps r?eeejay

thanks for the quick fix. let's get this change in 91.0b4 and 90.0.1

Comment 9

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-release/rev/3d2c70966045

Comment 10

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/82c1d5aac1b3

Comment 11

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I could not reproduce this issue.
I installed ZoomText(it was mentioned in the crash report) and searched for the top words(zoomtext, ورود, v900, keep, w, не, yahoo, mail, crash, sinc), went through some pdf's and graphs. Although ZoomText made the browser to feel sketchy, it did not crash, I used Fx 90.0 on Windows 10 x64.

Comment 12

[Julien Cristau [:jcristau]]

Added to 90.0.1 release notes:
"Fixed a crash when using some accessibility clients on Windows"

Comment 14

[Julien Cristau [:jcristau]]

No crashes so far with the fix, I'm going to call this verified.