Closed Bug 1720728 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29677 - Implement vertical stretchy operators

Categories

(Core :: MathML, task, P4)

task

Tracking

()

RESOLVED FIXED
92 Branch
Tracking Status
firefox92 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29677 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29677
Details from upstream follow.

b'Fr\xc3\xa9d\xc3\xa9ric Wang <fwang@igalia.com>' wrote:

Implement vertical stretchy operators

This is the first patch of a series of CL to implement MathML stretchy
operators. It only implements basic support for stretching operators
along the block axis (e.g. fences). This corresponds to the following
text in the spec with a few adjustments:

  1. "Otherwise, the stretch axis of the operator is block." from [1],
    but without symmetric/minsize/maxsize from steps 4 and 5.
    Additionally, due to current limitations in LayoutNG, one cannot
    implement "The inline size of the content is the width of the
    stretchy glyph" from step 6. Instead the approximate min/max size
    from step 2 is used during layout, which can lead to excessive
    gaps around vertical stretchy operators.

  2. Inserting [2] in the algorithm of the mrow layout [3].
    However, embellished operators [4] are not implemented yet.
    Instead, they are just treated to be equivalent to an \<mo> element.
    Additionally, step 1. is skipped for now since it only makes sense
    when the element using the mrow layout is itself an embellished
    operator.

[1] https://w3c.github.io/mathml-core/#layout-of-operators
[2] https://w3c.github.io/mathml-core/#algorithm-for-stretching-operators-along-the-block-axis
[3] https://w3c.github.io/mathml-core/#layout-of-mrow
[4] https://w3c.github.io/mathml-core/#dfn-embellished-operator

Bug: 6606, 1124301
Change-Id: If32c7c3e0177e78e273a2328c151c2b899e3acd1
Reviewed-on: https://chromium-review.googlesource.com/3013775
WPT-Export-Revision: ee04ff7aed2a176a3f2a2932e5000533c93eb36f

Component: web-platform-tests → MathML
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 4 subtests

Status Summary

Firefox

OK : 1
FAIL: 5

Chrome

OK : 1
PASS: 1
FAIL: 4

Safari

OK : 1
PASS: 1
FAIL: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/mathml/presentation-markup/mrow/stretch-along-block-axis-001.html
Taking into account stretchy property.: FAIL

New Tests That Don't Pass

/mathml/relations/css-styling/padding-border-margin/padding-border-margin-003.html: FAIL (Chrome: FAIL, Safari: FAIL)
/mathml/presentation-markup/mrow/stretch-along-block-axis-001.html
Taking into account stretch axis.: FAIL (Chrome: FAIL, Safari: FAIL)
Taking into account stretchy property.: FAIL (Chrome: PASS, Safari: PASS)
Only operators with a stretchy property and block stretch axis.: FAIL (Chrome: FAIL, Safari: FAIL)
Operators smaller and larger than non-stretchy siblings.: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2ef434f4c7c9 [wpt PR 29677] - Implement vertical stretchy operators, a=testonly https://hg.mozilla.org/integration/autoland/rev/dc361053abc2 [wpt PR 29677] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/30e0967e9b1f [wpt PR 29677] - Implement vertical stretchy operators, a=testonly https://hg.mozilla.org/integration/autoland/rev/30d60f29c52c [wpt PR 29677] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.