1720733 - Try to ensure SessionHistoryEntry::mFrameLoader isn't replaced accidentally

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P3)

Description

[Olli Pettay [:smaug][[e-mail]]]

I think there is one racy case when it may be replaced and thus Destroy on the old frameloader isn't called.
I believe the problematic case can happen if we have just started a new normal load (and already stored frameloader) and then do a session history load.

Patch coming

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1720733 - Try to ensure SessionHistoryEntry::mFrameLoader isn't replaced accidentally, r=peterv

I don't have a test for this, since the race condition is super hard to trigger.
The patch is based on code auditing.

The patch just prevents bfcaching if we're in middle of another load.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b68a422ad620
Try to ensure SessionHistoryEntry::mFrameLoader isn't replaced accidentally, r=peterv

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b68a422ad620