172075 - Need to flip chrome locale version from 1.0.1rc1 to 1.0.2 in brand.dtd

Status: VERIFIED DUPLICATE of bug 144551

(Core :: Internationalization: Localization, defect)

Description

[[e-mail] (away - not reading bugmail)]

noticed this when working on an embedding project. Lang version needs to be
flipped to 1.0.2 or else language packs can't be applied to Moz 1.0.2 builds.
This doesn't affect embedding. Perhaps we should consider ways of automating
this. The same problem has struck on the trunk (locale version wasn't flipped
from 1.2a to 1.2b).

<!ENTITY  lang.version          "1.0.1rc1">
<!ENTITY  brandShortName        "Mozilla">
<!ENTITY  vendorShortName       "Mozilla">
<!ENTITY  sidebarName           "Sidebar">

Comment 1

[[e-mail] (away - not reading bugmail)]

taking this

Comment 2

[[e-mail] (away - not reading bugmail)]

Attachment: proposed patch

Comment 3

[[e-mail] (away - not reading bugmail)]

tao, leaf,

I've noticed that leaf updated the locale version in the rest of the product to
1.0.2 on Sept 14, 2002 12:25. Was this perhaps done via a script? If so, could
we look into extending it to include brand.dtd? This bug keeps coming back in
virtually every release ;-)

Comment 4

[[e-mail] (away - not reading bugmail)]

Anyone up for r=/sr=? Let's get this out of the way ASAP...

Comment 5

[tao]

Comment on attachment 101378 [details] [diff] [review]
proposed patch

r=tao. I thought that leaf's
script does handle this
file. Leaf?

Comment 6

[[e-mail] (away - not reading bugmail)]

alecf, blizzard - would you have a second to sr= this?

Comment 7

[Christopher Blizzard (:blizzard)]

Comment on attachment 101378 [details] [diff] [review]
proposed patch

sr=blizzard

Comment 8

[[e-mail] (away - not reading bugmail)]

Tao, Chris thanks for the quick turnaround and your help in getting this
resolved quickly.

Comment 9

[Daniel Veditz [:dveditz]]

adt+ for the branch, please get a= before landing.

Comment 10

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 101378 [details] [diff] [review]
proposed patch

a=[e-mail] for 1.0 branch.  Change mozilla1.0.2+ to fixed1.0.2 when
checked in

Comment 11

[[e-mail] (away - not reading bugmail)]

Thanks everyone for the quick turnaround!

Comment 12

[Kasumi]

tested 2002-10-04-08-1.0
Win XP JA
I still can reproduce.

Comment 13

[[e-mail] (away - not reading bugmail)]

Kasumi, try a Mozilla branch build. Seems like the commercial tree hasn't 
pulled the change yet.

Mozilla 1.0 branch build still shows the content pack with a "needs update", 
the language pack seems fixed. I'm investigating it.

Comment 14

[[e-mail] (away - not reading bugmail)]

I searched the whole branch tree for remaining 1.0.1rc references and found 
another one in region.dtd. Sigh, we really need to fix the build scripts leaf 
is using, I've already emailed him about it. Looks like he'll be back next week.

I'm going to have Kasumi file a new bug for the region pack version mismatch. 
It makes the prebuilt content packs look as if they were out of date. That 
issue is not as severe as the brand.dtd mismatch we fixed in this bug, that 
issue effectively disables the locale switching UI.

Comment 15

[Kasumi]

tested on 2002-10-04-09-1.0
Win XP JA

Comment 16

[Kasumi]

not fixed on branch build 2002-10-23-08

Comment 17

[Kasumi]

For #15 tested on 2002-10-04-09-1.0 means Mozilla 2002-10-04-09-1.0
Not occur on Mozilla 2002-10-24-08-trunk either.
But still occur on 2002-10-24-08-trunk and 2002-10-24-08-1.0

Comment 18

[Frank Tang]

The remaining issue about Netscape is filed under
http://bugscape.mcom.com/show_bug.cgi?id=20674 also

Comment 19

[Daniel Veditz [:dveditz]]

I thought this was fixed... it's also bug 144551.

*** This bug has been marked as a duplicate of 144551 ***

Comment 20

[[e-mail] (away - not reading bugmail)]

This is fixed in Mozilla's branch, Netscape commercial build has a separate set
of DTD files to be changed. See http://bugscape.mcom.com/show_bug.cgi?id=20674.

This bug needs to be verified on a Mozilla branch build, Netscape branch builds
have a separate Bugscape bug.

Comment 21

[Kasumi]

Andreas said  that unless this problem is fixed in Netscape blanch, don't change
Keysord to verified 1.0.2. This is the reason why I can't verify.
As in #17, I have verified on Mozilla branch and trunk both.

Comment 22

[[e-mail] (away - not reading bugmail)]

It seems like were confusing ADT by keeping this open. Kasumi, not verifying is
fine by me, please just don't reopen the bug - unless it breaks on Mozilla
branch builds :-)

Commercial branch builds dated 10/29 or newer should be working fine as well.

Comment 23

[Kasumi]

Verified on commercial build 10-29-15-1.0