Closed Bug 1720805 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 29682 - Fix a few bugs in declarative Shadow DOM cloning

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
92 Branch
Tracking Flags:
Tracking Status
firefox92 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 29682 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/29682
Details from upstream follow.

b'Mason Freed <masonf@chromium.org>' wrote:

Fix a few bugs in declarative Shadow DOM cloning

Previously, the cloning operation would fail if the declarative shadow
root was sufficiently nested (e.g. inside another \<div> or inside a
nexted \<template>). This CL fixes this bug, by passing through the
CloneChildrenFlag to all the places it's needed.

Two new test conditions are added for the two broken cases.

Fixed: 1229311
Change-Id: I3e1fe7e6075e1aa74ff753c66ee209bd08a8a29c
Reviewed-on: https://chromium-review.googlesource.com/3033299
WPT-Export-Revision: a25a15ed86abfdccd53ec71c55d1213424bfd30a

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 8 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 14 subtests

Status Summary

Firefox

OK : 1
PASS: 3
FAIL: 11

Chrome

OK : 1
PASS: 12
FAIL: 2

Safari

OK : 1
PASS: 3
FAIL: 11

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/shadow-dom/declarative/declarative-shadow-dom-basic.tentative.html
Declarative Shadow DOM: Basic test: FAIL (Chrome: PASS, Safari: FAIL)
Declarative Shadow DOM: Feature detection: FAIL (Chrome: PASS, Safari: FAIL)
Declarative Shadow DOM: Fragment parser basic test: FAIL (Chrome: PASS, Safari: FAIL)
Declarative Shadow DOM: Closed shadow root attribute: FAIL (Chrome: PASS, Safari: FAIL)
Declarative Shadow DOM: Missing closing tag: FAIL (Chrome: PASS, Safari: FAIL)
Declarative Shadow DOM: delegates focus attribute: FAIL (Chrome: PASS, Safari: FAIL)
Declarative Shadow DOM: Multiple roots: FAIL (Chrome: PASS, Safari: FAIL)
Declarative Shadow DOM: template containing declarative shadow root: FAIL (Chrome: PASS, Safari: FAIL)
Declarative Shadow DOM: template containing (deeply nested) declarative shadow root: FAIL (Chrome: FAIL, Safari: FAIL)
Declarative Shadow DOM: template containing a template containing declarative shadow root: FAIL (Chrome: FAIL, Safari: FAIL)
Declarative Shadow DOM: template containing declarative shadow root and UA shadow root: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/753748265260 [wpt PR 29682] - Fix a few bugs in declarative Shadow DOM cloning, a=testonly https://hg.mozilla.org/integration/autoland/rev/833aece515be [wpt PR 29682] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/753748265260
https://hg.mozilla.org/mozilla-central/rev/833aece515be

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox92: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.