1720846 - Make the profiler buildable outside of `unified-build` environment

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P2)

Description

[Florian Quèze [:florian]]

tools/profiler and mozglue/baseprofiler should pass when running ./mach static-analysis check-syntax on them, and then we can add these folders to the list at https://searchfox.org/mozilla-central/source/build/non-unified-compat

Currently there are errors in tools/profiler/tests/gtest/LulTestInfrastructure.cpp, tools/profiler/core/platform.cpp (incomplete JS::RecordAllocationInfo type), mozglue/baseprofiler/core/ProfilerBacktrace.cpp and mozglue/baseprofiler/core/ProfilerBuffer.cpp.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

I'm getting build failures because of added files while working on bug 1716959, so I will work on this one now.

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1720846 - Fix non-unified build by adding missing #includes - r?florian

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1720846 - Add mozglue/baseprofiler and tools/profiler to non-unified-compat - r?florian

Depends on D120301

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46ecc01a4a63
Fix non-unified build by adding missing #includes - r=florian
https://hg.mozilla.org/integration/autoland/rev/ee08d481f68e
Add mozglue/baseprofiler and tools/profiler to non-unified-compat - r=florian

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/46ecc01a4a63
https://hg.mozilla.org/mozilla-central/rev/ee08d481f68e