1720888 - [XFA] Alignment issues - follow-up 3

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P2)

Description

[Daniel Bodea [:danibodea]]

Attachment: poppler-18935-0.pdf

+++ This bug was initially created as a clone of Bug #1719844 +++

+++ This bug was initially created as a clone of Bug #1718670 +++

Note

• When the user loads a specific PDF and compares its rendering with the one seen in Adobe, he will notice alignment issues.

Affected versions

• Nightly v92.0a1

Affected platforms

• all

Steps to reproduce

1. Launch browser.
2. Flip the pdfjs.enableXfa to true.
3. Load the attached PDF file.
4. Search for the areas in the demo pics.

Expected result

• The document is correctly displayed (as in Adobe Reader).

Actual result

• Alignment issues and overlapping are being observed.

Regression range

• This is not a regression.

Additional information:

Comment 1

[Daniel Bodea [:danibodea]]

Attachment: alignment issues poppler 2.png

Comment 2

[Daniel Bodea [:danibodea]]

Attachment: alignment issues poppler 2.1.png

Comment 3

[Daniel Bodea [:danibodea]]

Attachment: alignment issues poppler 2.2.png

Comment 4

[Daniel Bodea [:danibodea]]

Attachment: alignment issues poppler 2.3.png

Comment 5

[Calixte Denizet (:calixte)]

All of the different issues here have the same root cause: some text containers don't use the correct line height but the one from the font.
I've a wip locally to fix that.

Comment 6

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pdf.js/pull/13815

Comment 7

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub master push: https://github.com/mozilla/pdf.js/commit/edbe9692b48c6520e7cf90760ecdf2de3529db8f

Commit merged into master by GitHub
Authored by calixteman (calixteman)

Comment 8

[Marco Castelluccio [:marco]]

There is a minor alignment issue on page 1 ("w sposób przewidziany dla osób samotnie wychowujących dzieci"), but we can call this fixed.

Comment 9

[Daniel Bodea [:danibodea]]

The issues demonstrated in screenshots:

• alignment issues poppler 2.png
• alignment issues poppler 2.1.png
• alignment issues poppler 2.2.png
  are now fixed, but the last one:
• alignment issues poppler 2.3.png
  is NOT fixed.

To conclude, this issue is partially fixed and it will be closed as verified
A follow-up bug is reported for the remaining alignment issues: bug 1723173.