1721001 - Busted builds/worker/checkouts/gecko/js/src/wasm/WasmOpIter.h:3138:8: error: no matching member function for call to 'checkIsSubtypeOf' - when Gecko 92 merges to Beta on 2021-08-09

Status: VERIFIED FIXED

(Core :: JavaScript: WebAssembly, defect)

Description

[Noemi Erli[:noemi_erli]]

• central-as-beta simulation
  • How to run these simulations
  • Failure log
  • Failure log

[task 2021-07-17T11:26:32.490Z] 11:26:32 INFO - In file included from /builds/worker/checkouts/gecko/js/src/wasm/WasmBaselineCompile.cpp:152:
[task 2021-07-17T11:26:32.490Z] 11:26:32 ERROR - /builds/worker/checkouts/gecko/js/src/wasm/WasmOpIter.h:3138:8: error: no matching member function for call to 'checkIsSubtypeOf'
[task 2021-07-17T11:26:32.491Z] 11:26:32 INFO - if (!checkIsSubtypeOf(*rttSubTypeIndex, rttParentTypeIndex)) {
[task 2021-07-17T11:26:32.491Z] 11:26:32 INFO - ^~~~~~~~~~~~~~~~
[task 2021-07-17T11:26:32.491Z] 11:26:32 INFO - /builds/worker/checkouts/gecko/js/src/wasm/WasmBaselineCompile.cpp:14121:14: note: in instantiation of member function 'js::wasm::OpIter<js::wasm::BaseCompiler::BaseCompilePolicy>::readRttSub' requested here
[task 2021-07-17T11:26:32.492Z] 11:26:32 INFO - if (!iter_.readRttSub(&nothing, &rttSubTypeIndex)) {
[task 2021-07-17T11:26:32.492Z] 11:26:32 INFO - ^
[task 2021-07-17T11:26:32.493Z] 11:26:32 INFO - /builds/worker/checkouts/gecko/js/src/wasm/WasmOpIter.h:414:15: note: candidate function not viable: no known conversion from 'uint32_t' (aka 'unsigned int') to 'js::wasm::ValType' (aka 'PackedType<js::wasm::ValTypeTraits>') for 1st argument
[task 2021-07-17T11:26:32.494Z] 11:26:32 INFO - inline bool checkIsSubtypeOf(ValType actual, ValType expected);
[task 2021-07-17T11:26:32.495Z] 11:26:32 INFO - ^
[task 2021-07-17T11:26:32.496Z] 11:26:32 INFO - /builds/worker/checkouts/gecko/js/src/wasm/WasmOpIter.h:415:15: note: candidate function not viable: no known conversion from 'uint32_t' (aka 'unsigned int') to 'js::wasm::ResultType' for 1st argument
[task 2021-07-17T11:26:32.496Z] 11:26:32 INFO - inline bool checkIsSubtypeOf(ResultType params, ResultType results);
[task 2021-07-17T11:26:32.497Z] 11:26:32 INFO - ^
[task 2021-07-17T11:26:32.498Z] 11:26:32 INFO - 1 error generated.
[task 2021-07-17T11:26:32.499Z] 11:26:32 ERROR - make[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:693: Unified_cpp_js_src_wasm0.o] Error 1
[task 2021-07-17T11:26:32.500Z] 11:26:32 INFO - make[4]: Leaving directory '/builds/worker/workspace/obj-build/js/src/wasm'
[task 2021-07-17T11:26:32.501Z] 11:26:32 INFO - make[4]: *** Waiting for unfinished jobs....

Comment 1

[Ryan Hunt [:rhunt]]

Attachment: Bug 1721001 - wasm: Fix bustage due to missing ifdefs. r?yury

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ceabe0ed1244
wasm: Fix bustage due to missing ifdefs. r=yury

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ceabe0ed1244

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed with today's central-as-beta simulation.