1721197 - Cover restoring breakpoint after toolbox closing

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Alexandre Poirot [:ochameau]]

Bug 1720512 highlighted that we were (at least) not testing trying to restore breakpoints set on evaled sources.
These breakpoints are not restored as there isn't a good way to designated the transient evaled sources. And in bug 1720512 we were trying to restore them and crashing the debugger.

We might have some test already covering breakpoint restore, but not this particular case?
Thanks to such test, we can them more easily work on bug 1721180, knowing that we have some coverage.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1721197 - [devtools] Add test re-opening the toolbox after setting breakpoints in evaled sources

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2a97835b604
[devtools] Add test re-opening the toolbox after setting breakpoints in evaled sources r=ochameau

Comment 3

[Atila Butkovits]

Backed out for causing dt failures at browser_dbg-breakpoints-in-evaled-sources.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/ca94a827a5180879fe46b016ae7d7d831b1cb8e4

Push where failures appeared: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=deb455d7a744a7d2bb0fdee634b848640ba18c39&searchStr=dt&selectedTaskRun=FtmyH1kNTxmc-E1XwyZXww.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=345937648&repo=autoland&lineNumber=4835

Comment 4

[Julian Descottes [:jdescottes]]

Didn't notice the backout, will check later today.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be8a735e3c71
[devtools] Add test re-opening the toolbox after setting breakpoints in evaled sources r=ochameau

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/be8a735e3c71