1721200 - Use zoom factor for all screenshot types

Status: RESOLVED WONTFIX

(Firefox :: Screenshots, defect)

Description

[Emma Malysz]

The zoom factor is only used for full page screenshots: https://searchfox.org/mozilla-central/source/browser/extensions/screenshots/background/takeshot.js#47

Let's move this out of the if block

Comment 1

[Emma Malysz]

Attachment: Bug 1721200, set zoomFactor for all screenshots other than save visible

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1710635

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:emalysz, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 4

[Emma Malysz]

After taking a closer look at this bug, the zoom factor should not be incorporated into the save visible (which captures the current viewport) or the selector elements.

We will produce cropped screenshots if we do so. I think the main bug to fix here is Bug 1721198 and factoring in device pixel ratios.