1721214 - nsIServiceWorkerManager registerForTest and registerForAddonPrincipal should return a rejected promise on calls that fail due to invalid parameters

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

While working on other issue related to the service workers and WebExtensions I did notice that these two ServiceWorkerManager methods are missing to call outer.forget(aPromise) before early returning due to invalid parameters (my apologies, I shouldn't have missed that).

The missing call to outer.forget(aPromise) isn't currently triggering any particular issue (because RegisterForTest is only used in test and a test would still fail because of the uncaught rejection related to the promise rejected internally and never returned by that method, and RegisterForAddonPrincipal is currently nightly only and not allowed yet on non nightly channels), but it is wrong and it should be fixed.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1721214 - ServiceWorkerManager RegisterForTest and RegisterForAddonPrincipal should return a rejected promise on invalid call parameters. r?asuth!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d91e3fa4008
ServiceWorkerManager RegisterForTest and RegisterForAddonPrincipal should return a rejected promise on invalid call parameters. r=asuth

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4d91e3fa4008