1721239 - Put newtab story collections behind a feature flag

Status: RESOLVED FIXED

(Firefox :: Pocket, enhancement, P1)

Description

[Scott [:thecount] Downe]

We make requests to the backend for Pocket newtab story collections, and let the data returned be the deciding factor to showing a collection or not.

It'll be optimal to not add the collection position to the request unless we're going to use it, so we're going to put this feature behind a feature flag. Then the client can read that flag and decide to include collections or not.

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1721239 - Move newtab Pocket collections behind a pref.

Comment 2

[Scott [:thecount] Downe]

Attachment: Bug 1721239 - Pocket newtab server signal to toggle pocket collections.

Comment 3

[Scott [:thecount] Downe]

Steps to test:

the default state should be no collections. So after a cache reset, the new collections pref should still be false.

1. Set browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to true
2. Open about:home#devtools-ds
3. Click "Refresh Cache"
   Expected: The pref for browser.newtabpage.activity-stream.discoverystream.sponsored-collections.enabled should still be false.

This also touched a bit of the layout rendering code, so doing a little regression tests for basic layout and spoc position is a good idea.
Spoc positions

1. Verify newtab spoc positions match what is in the pref browser.newtabpage.activity-stream.discoverystream.spoc-positions
2. Change browser.newtabpage.activity-stream.discoverystream.spoc-positions to something like 0,1,2,3
3. Reload newtab
   Expected: ensure spocs are in positions 1, 2, 3, 4.

Basic layout

1. Ensure newtab is 7 rows of content.
2. flip browser.newtabpage.activity-stream.discoverystream.hardcoded-basic-layout to true
3. Reload newtab.
   Expected: Should be 1 row of stories now.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c55a9d422f8d
Pocket newtab server signal to toggle pocket collections. r=gvn

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/c55a9d422f8d