1721333 - Convert some private slot uses to reserved slots

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Jan de Mooij [:jandem]]

Most of these are easy to convert before fixing the more complicated ones later on.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1721333 part 1 - Remove DebuggerMemory's unused private slot. r?jonco!

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1721333 part 2 - Remove SavedFrame's unused private slot. r?jonco!

Depends on D120307

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1721333 part 3 - Remove WasmRuntimeExceptionObject's unused private slot. r?jonco!

Depends on D120308

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1721333 part 4 - Remove unused private slot from WeakMap jsapi-test. r?jonco!

Depends on D120309

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Bug 1721333 part 5 - Use a reserved slot instead of private slot for DebuggerInstanceObject. r?jonco!

Depends on D120310

Comment 6

[Jan de Mooij [:jandem]]

Attachment: Bug 1721333 part 6 - Use a reserved slot instead of private slot for MapObject and SetObject. r?jonco!

Depends on D120311

Comment 7

[Jan de Mooij [:jandem]]

Attachment: Bug 1721333 part 7 - Use a reserved slot instead of private slot for WeakMapObject and WeakSetObject. r?jonco!

Depends on D120312

Comment 8

[Jan de Mooij [:jandem]]

Attachment: Bug 1721333 part 8 - Use a reserved slot instead of private slot for PropertyIteratorObject. r?jonco!

Depends on D120313

Comment 9

[Jan de Mooij [:jandem]]

Attachment: Bug 1721333 part 9 - Use a reserved slot instead of private slot for RegExpStaticsObject. r?jonco!

Depends on D120314

Comment 10

[Jan de Mooij [:jandem]]

Attachment: Bug 1721333 part 10 - Use a reserved slot instead of private slot for ForOfPICObject. r?jonco!

Depends on D120315

Comment 11

[Jan de Mooij [:jandem]]

Attachment: Bug 1721333 part 11 - Use a reserved slot instead of private slot for testResolveRecursion. r?jonco!

Depends on D120316

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5bd8cb5f0cf1
part 1 - Remove DebuggerMemory's unused private slot. r=jonco
https://hg.mozilla.org/integration/autoland/rev/6ecc217611cd
part 2 - Remove SavedFrame's unused private slot. r=jonco
https://hg.mozilla.org/integration/autoland/rev/b99eb964a0e5
part 3 - Remove WasmRuntimeExceptionObject's unused private slot. r=jonco
https://hg.mozilla.org/integration/autoland/rev/93f6b564d874
part 4 - Remove unused private slot from WeakMap jsapi-test. r=jonco
https://hg.mozilla.org/integration/autoland/rev/34432903f003
part 5 - Use a reserved slot instead of private slot for DebuggerInstanceObject. r=jonco
https://hg.mozilla.org/integration/autoland/rev/bcab21e83d90
part 6 - Use a reserved slot instead of private slot for MapObject and SetObject. r=jonco
https://hg.mozilla.org/integration/autoland/rev/a10364bc1e8a
part 7 - Use a reserved slot instead of private slot for WeakMapObject and WeakSetObject. r=jonco
https://hg.mozilla.org/integration/autoland/rev/6cac736dc557
part 8 - Use a reserved slot instead of private slot for PropertyIteratorObject. r=jonco
https://hg.mozilla.org/integration/autoland/rev/e370430b2eb9
part 9 - Use a reserved slot instead of private slot for RegExpStaticsObject. r=jonco
https://hg.mozilla.org/integration/autoland/rev/34e934fb301d
part 10 - Use a reserved slot instead of private slot for ForOfPICObject. r=jonco
https://hg.mozilla.org/integration/autoland/rev/64c2f8b78188
part 11 - Use a reserved slot instead of private slot for testResolveRecursion. r=jonco

Comment 13

[Marian-Vasile Laza]

Backed out 11 changesets (Bug 1721333) for causing crashtest/mochitest assertion failures on NativeObject.h.
Backout link
Push with failures
Failure Log

There are also Xpcshell failures in: https://treeherder.mozilla.org/logviewer?job_id=345749790&repo=autoland&lineNumber=4427

Comment 14

[Alexandru Michis [:malexandru]]

Update: also causes these bc failures.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb928a2e7175
part 1 - Remove DebuggerMemory's unused private slot. r=jonco
https://hg.mozilla.org/integration/autoland/rev/ef9bb71e19d1
part 2 - Remove SavedFrame's unused private slot. r=jonco
https://hg.mozilla.org/integration/autoland/rev/722290879d00
part 3 - Remove WasmRuntimeExceptionObject's unused private slot. r=jonco
https://hg.mozilla.org/integration/autoland/rev/14919599edee
part 4 - Remove unused private slot from WeakMap jsapi-test. r=jonco
https://hg.mozilla.org/integration/autoland/rev/4cf3b2833ae1
part 5 - Use a reserved slot instead of private slot for DebuggerInstanceObject. r=jonco
https://hg.mozilla.org/integration/autoland/rev/afdf120fa94c
part 6 - Use a reserved slot instead of private slot for MapObject and SetObject. r=jonco
https://hg.mozilla.org/integration/autoland/rev/7027d71565f9
part 7 - Use a reserved slot instead of private slot for WeakMapObject and WeakSetObject. r=jonco
https://hg.mozilla.org/integration/autoland/rev/97f0e495e8aa
part 8 - Use a reserved slot instead of private slot for PropertyIteratorObject. r=jonco
https://hg.mozilla.org/integration/autoland/rev/422a5017356a
part 9 - Use a reserved slot instead of private slot for RegExpStaticsObject. r=jonco
https://hg.mozilla.org/integration/autoland/rev/a072132eb07e
part 10 - Use a reserved slot instead of private slot for ForOfPICObject. r=jonco
https://hg.mozilla.org/integration/autoland/rev/ace05b9fe420
part 11 - Use a reserved slot instead of private slot for testResolveRecursion. r=jonco

Comment 16

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/eb928a2e7175
https://hg.mozilla.org/mozilla-central/rev/ef9bb71e19d1
https://hg.mozilla.org/mozilla-central/rev/722290879d00
https://hg.mozilla.org/mozilla-central/rev/14919599edee
https://hg.mozilla.org/mozilla-central/rev/4cf3b2833ae1
https://hg.mozilla.org/mozilla-central/rev/afdf120fa94c
https://hg.mozilla.org/mozilla-central/rev/7027d71565f9
https://hg.mozilla.org/mozilla-central/rev/97f0e495e8aa
https://hg.mozilla.org/mozilla-central/rev/422a5017356a
https://hg.mozilla.org/mozilla-central/rev/a072132eb07e
https://hg.mozilla.org/mozilla-central/rev/ace05b9fe420