Closed Bug 1721349 Opened 4 years ago Closed 4 years ago

Potential leak caused by HTMLFormSubmission::mSubmitter isn't cycle-collected

Categories

(Core :: DOM: Forms, defect, P2)

defect

Tracking

()

RESOLVED FIXED
92 Branch
Tracking Status
firefox92 --- fixed

People

(Reporter: edgar, Assigned: edgar)

References

Details

Attachments

(1 file)

Found this while writing a wpt test for bug 1653625.
HTMLFormSubmission::mSubmitter is exposed to the webpage via FormData, but it isn't cycle-collected, so if it participates in cycle references, we are unable to cycle-collect it and cause a leak.

Blocks: 1653625

Thanks for finding and fixing this!

Attachment #9232142 - Attachment description: Bug 1721349 - Move mSubmitter from HTMLFormSubmission to FormData and make it participating in cycle collector; r=mccr8 → Bug 1721349 - Move mSubmitter from HTMLFormSubmission to FormData and make it participate in cycle collection; r=mccr8
Pushed by echen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/312aa83dc7ed Move mSubmitter from HTMLFormSubmission to FormData and make it participate in cycle collection; r=mccr8
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: