1721364 - browser_toolbox_window_title_frame_select.js fails with server side target switching enabled

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Alexandre Poirot [:ochameau]]

$ ./mach mochitest --headless devtools/client/framework/test/browser_toolbox_window_title_frame_select.js --setpref devtools.target-switching.server.enabled=true

This test fails because the BrowsingContextTargetActor doesn't emit window-destroyed when server side targets are enabled and we use the iframe dropdown to switch to another iframe.
The following check disable this event:
https://searchfox.org/mozilla-central/source/devtools/server/actors/targets/browsing-context.js#1418-1421
This ultimately prevents the Walker Actor to emit the new ROOT_NODE and makes this test fail with a timeout.

We should simply allow this event in case of iframe switching, exactly like what we do for window-ready:
https://searchfox.org/mozilla-central/rev/79a3ae0b0fa6abeca2cb7cf220df293c8dec9207/devtools/server/actors/targets/browsing-context.js#1399-1404

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1721364 - [devtools] Fix devtools/client/framework/test/browser_toolbox_window_title_frame_select.js with server side targets.

We weren't emitting window-ready in case of iframe switching,
leading to some breakage in walker actor not updating correctly when using the iframe dropdown.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc68b95b69ce
[devtools] Fix devtools/client/framework/test/browser_toolbox_window_title_frame_select.js with server side targets. r=nchevobbe

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/fc68b95b69ce