1721369 - browser_inspector_highlighter-eyedropper-xul.js fails with server side target switching enabled

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Alexandre Poirot [:ochameau]]

./mach mochitest --headless devtools/client/inspector/test/browser_inspector_highlighter-eyedropper-xul.js --setpref devtools.target-switching.server.enabled=true

This test seems to fails because of a pending promise that is rejected.
And because the test harness see such unhandled rejected promise, it reports a failure.
But at first sight, it is probably a pending request made against the previous, destroyed target, which we may just ignore.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1721369 - [devtools] Fix devtools/client/inspector/test/browser_inspector_highlighter-eyedropper-xul.js

First, we could get rid of old promises... the async stack would be easier to read.

Then, there is this call to apply which is async and rejected.
Could it be done against the previous, destroying or to be destroyed target?

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

so this is failing when we navigate:

• will-navigate is emitted
• the inspector set the selected node front to null
• the color picker, which is still open, gets closed
• this triggers onTooltipHidden, which calls commit, which calls previewPropertyValue , apply and finaly setRuleText
• the connection gets closed while the call is pending

so we can't check if the ruleFront is destroyed before calling setRuleText, as it's not destroyed yet.

We might want to:

• close the tooltip in the test before navigating (this does fix the test)
• add a try/catch block or a catch callback when calling one of the promise in rule-rewriter.js
• don't call commit from SwatchBasedEditorTooltip when the tooltip gets closed (here in the base swatch class https://searchfox.org/mozilla-central/rev/523ac2e17550f1f1da16aacdc6ac647af8b35508/devtools/client/shared/widgets/tooltip/SwatchBasedEditorTooltip.js#123). It's not useful for the color tooltip, but maybe it is for other tooltips.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1721369 - [devtools] Fix browser_inspector_highlighter-eyedropper-xul.js with server side target switching enabled. r=ochameau.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee8e0e45d89f
[devtools] Fix browser_inspector_highlighter-eyedropper-xul.js with server side target switching enabled. r=ochameau.

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ee8e0e45d89f