Closed Bug 1721384 Opened 3 years ago Closed 3 years ago

browser_net_websocket_stacks.js fails with server side target switching enabled

Categories

(DevTools :: Netmonitor, defect)

defect

Tracking

(Fission Milestone:MVP, firefox92 fixed)

RESOLVED FIXED
92 Branch
Fission Milestone MVP
Tracking Status
firefox92 --- fixed

People

(Reporter: ochameau, Assigned: bomsy)

References

Details

(Whiteboard: dt-fission-m3-mvp)

Attachments

(1 file, 1 obsolete file)

./mach mochitest --headless devtools/client/netmonitor/test/browser_net_websocket_stacks.js --setpref devtools.target-switching.server.enabled=true

This test fail because we try to fetch the stack trace for the first navigation request.
And we try to do that late, after the navigation is completed.
The previous target we navigate from has been destroyed and we can't communicate with the previous network content actor and so can't fetch the stack trace.

The test is stuck on this line:
https://searchfox.org/mozilla-central/rev/79a3ae0b0fa6abeca2cb7cf220df293c8dec9207/devtools/client/netmonitor/test/browser_net_websocket_stacks.js#89
Because the following RDP request call will be stuck:
https://searchfox.org/mozilla-central/rev/79a3ae0b0fa6abeca2cb7cf220df293c8dec9207/devtools/client/netmonitor/src/connector/firefox-data-provider.js#313-315
(surprinsingly it seems to not be rejected it just never resolves?)
You will notice that for the first request, actor.targetFront will be different from any other request and will be the previous target, which is already destroyed.

Assignee: nobody → hmanilla
Status: NEW → ASSIGNED
Pushed by hmanilla@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/acf8c90ef510 [devtools] Fix browser_net_websocket_stacks.js with server side targets r=jdescottes
Fission Milestone: --- → MVP
Whiteboard: dt-fission-m3-triage → dt-fission-m3-mvp
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
Attachment #9232158 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: