1721403 - browser_target_list_switchToTarget.js fails with server side target switching enabled

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[Alexandre Poirot [:ochameau]]

$ ./mach mochitest --headless devtools/shared/commands/target/tests/browser_target_list_switchToTarget.js --setpref devtools.target-switching.server.enabled=true

This test fails because TabDescriptor.getTarget only works if a dedicated TargetCommand runs alongside.
Whereas this test only spawn a commands and TargetCommand for the first tab and not the second.

https://searchfox.org/mozilla-central/rev/79a3ae0b0fa6abeca2cb7cf220df293c8dec9207/devtools/client/fronts/descriptors/tab.js#228-240

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1721403 - [devtools] Fix browser_target_list_switchToTarget.js with server side targets.

TabDescriptor.getTarget now only works if a TargetCommand is setup
and we called startListening on it.
And there is no way to retrieve another tab's target from
a given tab's TargetCommand/commands.

So here we should use two distinct commands.
Note that this test is covering cases we don't really support.
Switching between two distinct tab's top targets isn't something that should happen.
But I think it is still valuable to cover as it may later help us work on bug 1569859.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b88bef98c4c9
[devtools] Fix browser_target_list_switchToTarget.js with server side targets. r=jdescottes

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b88bef98c4c9