1721472 - Glean Error: TypeError: an integer is required

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, defect, P3)

Description

[Barret Rennie [:barret] (they/them)]

When running ./mach vendor rust I got the following log:

$ ./mach vendor rust
    Updating crates.io index
    Updating git repository `https://github.com/mozilla-spidermonkey/jsparagus`
    Updating git repository `https://github.com/mozilla/neqo`
    Updating git repository `https://github.com/mozilla/audioipc-2`
    Updating git repository `https://github.com/mozilla/cubeb-coreaudio-rs`
    Updating git repository `https://github.com/mozilla/cubeb-pulse-rs`
    Updating git repository `https://github.com/jfkthame/mapped_hyph.git`
    Updating git repository `https://github.com/mozilla/mp4parse-rust`
    Updating git repository `https://github.com/mozilla/application-services`
    Updating git repository `https://github.com/PLSysSec/lucet_sandbox_compiler`
    Updating git repository `https://github.com/gfx-rs/gfx`
    Updating git repository `https://github.com/gfx-rs/naga`
    Updating git repository `https://github.com/kinetiknz/ashmem-rs`
    Updating git repository `https://github.com/kinetiknz/mio-named-pipes`
      Adding unix_path v1.0.1
      Adding unix_str v1.0.0
 0:44.64 Glean error
Sentry is attempting to send 0 pending error messages
Waiting up to 2 seconds
Press Ctrl-Break to quit

Due to bug 1721471, the actual stack trace isn't logged, but I added some logging and got the following trace:

Traceback (most recent call last):
  File "c:\Users\Barret\.mozbuild\_virtualenvs\mach\lib\site-packages\glean\_dispatcher.py", line 123, in _worker
    task(*args, **kwargs)
  File "c:\Users\Barret\.mozbuild\_virtualenvs\mach\lib\site-packages\glean\metrics\boolean.py", line 63, in set     
    _ffi.lib.glean_boolean_set(self._handle, value)
TypeError: an integer is required

Comment 1

[Mitchell Hentges [:mhentges] 🦀]

This is probably because we're providing the wrong type for one of the values. Will dig into this.

Comment 2

[Barret Rennie [:barret] (they/them)]

Attachment: Bug 1721472 - Correctly return whether or not we are in an SSH connection r?mhentges

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad05e0780151
Correctly return whether or not we are in an SSH connection r=mhentges

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ad05e0780151

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1702172

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Uplifting this a=NPOTB since it's foreseeable we'll hit this on ESR91 eventually at some point during its lifecycle.

https://hg.mozilla.org/releases/mozilla-beta/rev/a8af9b01fff38e4ec5ef4d930f58e02811abc704