1721477 - Linux build instructions suggest bad modification to .bashrc

Status: RESOLVED FIXED

(Firefox Build System :: Build Documentation, defect)

Description

[Markus Stange [:mstange]]

This bug is about the suggestion in the "Note" box in the "Install Mercurial" section:

https://firefox-source-docs.mozilla.org/setup/linux_build.html?highlight=linux%20build#install-mercurial

Once pip has installed mercurial, on a fresh Ubuntu install, hg version doesn't work because the Python packages aren't in the path. The Note box handles this case, however, this suggestion is no good:

# If you're using bash
echo "export PATH=\"$(python3 -m site --user-base)/bin:$PATH\"" >> ~/.bashrc

The $PATH variable is resolved, and what ends up in the .bashrc file no longer has the dollar sign. It has the fully resolved PATH at the time the echo command was invoked.

I think this needs a backslash before the dollar sign.

I'm not sure if the same is needed for zsh.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1721477 - Fix documentation suggestion for PATH augmentation.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5937b6071540
Fix documentation suggestion for PATH augmentation. r=firefox-build-system-reviewers,andi

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5937b6071540