172158 - View Source -> File -> Save Page As.. Crashes browser [@ XPCWrappedNative::CallMethod]

Status: VERIFIED DUPLICATE of bug 172586

(SeaMonkey :: Installer, defect)

Description

[Nick Lott]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2b) Gecko/20021001
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2b) Gecko/20021001

Mozilla crashes when you try to save the source to a file from the view source
window.

Reproducible: Always

Steps to Reproduce:
1.Go to a page
2.View Source
3.File -> Save Page As..


Actual Results:  
Broswer crashes


TalkBackIDs: TB11926038Y & TB11925976E

Comment 1

[David Bradley]

Stack from TB11926038Y:

XPCWrappedNative::CallMethod [js/src/xpconnect/src/xpcwrappednative.cpp, line 2173]
XPC_WN_CallMethod [js/src/xpconnect/src/xpcwrappednativejsops.cpp, line 1267]
js_Invoke [js/src/jsinterp.c, line 841]
js_Interpret [js/src/jsinterp.c, line 2804]
js_Invoke [js/src/jsinterp.c, line 857]
nsXPCWrappedJSClass::CallMethod [js/src/xpconnect/src/xpcwrappedjsclass.cpp,
line 1195]
nsXPCWrappedJS::CallMethod [js/src/xpconnect/src/xpcwrappedjs.cpp, line 430]
PrepareAndDispatch [xpcom/reflect/xptcall/src/md/win32/xptcstubs.cpp, line 117]
SharedStub [xpcom/reflect/xptcall/src/md/win32/xptcstubs.cpp, line 139]
nsURIChecker::SetStatusAndCallBack [netwerk/base/src/nsURIChecker.cpp, line 76]
nsURIChecker::OnStartRequest [netwerk/base/src/nsURIChecker.cpp, line 231]
nsHttpChannel::OnStartRequest [netwerk/protocol/http/src/nsHttpChannel.cpp, line
2905]
nsOnStartRequestEvent::HandleEvent [netwerk/base/src/nsRequestObserverProxy.cpp,
line 162]
PL_HandleEvent [xpcom/threads/plevent.c, line 645]
PL_ProcessPendingEvents [xpcom/threads/plevent.c, line 578]
_md_EventReceiverProc [xpcom/threads/plevent.c, line 1336]
nsAppShellService::Run [xpfe/appshell/src/nsAppShellService.cpp, line 472]
main1 [xpfe/bootstrap/nsAppRunner.cpp, line 1538]
main [xpfe/bootstrap/nsAppRunner.cpp, line 1886]
WinMain [xpfe/bootstrap/nsAppRunner.cpp, line 1906]
WinMainCRTStartup()  
KERNEL32.DLL + 0x17d08 (0x77e97d08)  

Registers:
EAX: 00000000 EBX: 0012f415 ECX: 02981ed8 EDX: 00f7f52c
ESI: 0012f5a0 EDI: 02981ed8 ESP: 0012f3f8 EBP: 0012f584
EIP: 60fd1f51 cf pf af zf sf of IF df nt RF vm   IOPL: 0
CS: 001b DS: 0023 SS: 0023 ES: 0023 FS: 0038 GS: 0000

Comment 2

[David Bradley]

The line number is a little odd. If it's anywhere near correct, looks like
something might have deleted an out parameter.

Comment 3

[Frederic Bezies]

WFM - trunk build 2002100204 - WinXP-SP1.

Comment 4

[greer]

This one is in the top 15 on the Trunk currently, but has shown up in N700 and
M1.2a also -> topcrash.

Comment 5

[greer]

Attachment: Breakdown of builds, users, comments, URL's by release

per timeless, comments and URL's. Not a lot there.

Comment 6

[timeless]

i'm going to make the outlandish claim that this isn't viewsource's fault :)

Comment 7

[Boris Zbarsky [:bzbarsky]]

OK.. Is this windows-only?  I'm unable to reproduce this on Linux....

This is not likely to be a pure file-handling issue since that's all JS code and
"JS should not crash".  But yes, the call happens when we call out of file
handling code to _somewhere_.  Would be nice to know where the somewhere was....

Comment 8

[timeless]

wfm Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2b) Gecko/20021003
This was a mozilla-win32-talkback.zip build.

there's a running discussion about talkback.zip v. installer, would people who
are crashing please indicate which they used, and how (fresh install, install over).

note that the bug was vague, so i used ctrl-u on this bug and then file>saveas
and browsed to my desktop and gave it a name.

Comment 9

[Nick Lott]

OK, as indicated above this is not just affecting viewsource, it seems to be any
file handling operation within the browser. 
Affected operations include:

File->Save Page As...        in the main browser window
Save Link Target As...       also in the main window. 
    (If I just click a link to a file I get an error but no crash, see
attachment. Permissions on this folder are set correctly)

However, I can do file operations from within the bookmark manager with no problems.

History: I was using the 1.2a release without any problems until the beginning
of this week, when I installed build 20021001. These (and other) problems
started then. I installed it over the old version using the stub installer
(http://ftp.mozilla.org/pub/mozilla/nightly/latest/mozilla-win32-installer.exe). 
Yesterday I installed 20021002 (not using the stub installer but the nightly
build link on the front page) over the top of that build and continue to have
the same problems. As to talkback, I've got whatever came with the mozilla
installer.

The crash occurs the moment I click the save as.. menu item (which ever one it
might be), I don't get chance to browse anywhere.

I'm also suffering from other crashes that never occured before, namely Bug
170465 & Bug 172339. Whether they are related in anyway I have no idea.

Comment 10

[Nick Lott]

Attachment: Error when following link to a file

Comment 11

[Boris Zbarsky [:bzbarsky]]

Nick, please delete your compreg.dat file and see if that helps?

Comment 12

[Nick Lott]

No, deleting compreg.dat doesn't seem to make a difference

Comment 13

[timeless]

Attachment: list of known reasonable xpt files

Ok, the current best candidate culprit is outdated xpt files, I'll provide a
list of files I expect to see in a mozilla components directory, if you have
*any* others, please move them out of the way, then run regxpcom and see what
happens.

In short: if you see an xpt file which has a date that doesn't match the others
it's probably unhealthy, here are two examples:
07/24/2002  10:11a		 3,828 calendar.xpt
09/06/2002  04:41a		   982 gfx2.xpt

Note that calendar is unlikely to cause me harm because of what it is.	gfx2 is
another story.

In the install (installer, not zip) I was playing with, I had n7 xpt files
(browser.xpt, mail.xpt, psm.xpt) and they seemed to contribute chaos.

If the problem ends up being xpt files, I think this will be dbradley's bug and
we'll need to work on automatically deleting 'old' xpt files when two xpt files
list the same interface.

Comment 14

[timeless]

note that by *any* others i mean any other[ xpt file]s, if you delete all of the
dll/so files from the components directory, mozilla won't be very happy...

Comment 15

[Nick Lott]

Cool, that worked, and how! 
Deleting browser.xpt, mail.xpt, psm.xpt and compreg.dat fixes this bug plus bug
171441, bug 172339 AND bug 170465.
Someone might want to mark them as resolved or something as at least one is a
topcrash.

Comment 16

[Nick Lott]

Also fixes bug 172108 and the problem I reported in bug 163577 comment 5

Comment 17

[Boris Zbarsky [:bzbarsky]]

To dbradley per comment 13

Comment 18

[(not reading, please use [e-mail] instead)]

is the trick to this bug, like the other recent mailnews crashers, to install
into a fresh directory?

Comment 19

[Christian :Biesinger (don't email me, ping me on IRC)]

sspitzer, per comment 15 I'd say that installing into a new directory would work
as well.

Comment 20

[Bill Mason]

Nominating for 1.2 since it blocks the also nominated bug 171441

Comment 21

[Matthias Versen [:Matti]]

*** Bug 172754 has been marked as a duplicate of this bug. ***

Comment 22

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Duplicate of bug 172586?  There haven't been any talkback reports on this since
10-07 (like a bunch of other bugs that are duplicates of bug 172586).

Comment 23

[Brian Ryner (not reading)]

Yep, what dbaron said.

*** This bug has been marked as a duplicate of 172586 ***

Comment 24

[Boris Zbarsky [:bzbarsky]]

Most of the bugs this bug blocks are likely dups as well....

Comment 25

[David G King]

As this is a dup of Bug #172586, removed dependency on Bug #172586.

Comment 26

[K'Trina Medina]

Verified as a dupe of bug 172586