1721639 - Refactor string and bigint creation methods to take gc::InitialHeap

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P3)

Description

[Jon Coppeard (:jonco)]

Currently, the macroassembler methods to create strings and bigints take a boolean to indicate whether to allocate in the nursery, whereas the object creation methods take a gc::InitialHeap parameter.

To enable pretenuring of these allocations (and for general consistency) we can refactor so that everything takes an InitialHeap.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1721639 - Make failure label last parameter for bigint creation methods r?jandem

First of all, swap the parameter order for bigint creation methods so that
failure label is last, as seems to be the convention elsewhere.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1721639 - Replace boolean with gc::InitialHeap parameter for bigint creation methods r?jandem

Depends on D120489

Comment 3

[Jon Coppeard (:jonco)]

Attachment: Bug 1721639 - Make failure label last parameter for string creation methods r?jandem

Like the previous patch, make the failure label the last parameter.

Depends on D120490

Comment 4

[Jon Coppeard (:jonco)]

Attachment: Bug 1721639 - Replace boolean with gc::InitialHeap parameter for string creation methods r?jandem

Depends on D120491

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62bf5291afb8
Make failure label last parameter for bigint creation methods r=jandem
https://hg.mozilla.org/integration/autoland/rev/19c48d58751e
Replace boolean with gc::InitialHeap parameter for bigint creation methods r=jandem
https://hg.mozilla.org/integration/autoland/rev/fc379b04b606
Make failure label last parameter for string creation methods r=jandem
https://hg.mozilla.org/integration/autoland/rev/1da1c6811098
Replace boolean with gc::InitialHeap parameter for string creation methods r=jandem

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/62bf5291afb8
https://hg.mozilla.org/mozilla-central/rev/19c48d58751e
https://hg.mozilla.org/mozilla-central/rev/fc379b04b606
https://hg.mozilla.org/mozilla-central/rev/1da1c6811098