Closed Bug 1721703 Opened 4 years ago Closed 4 years ago

Fix incorrect usage of assertPausedLocation in Debugger mochitests

Categories

(DevTools :: Debugger, task, P3)

task

Tracking

(firefox92 fixed)

RESOLVED FIXED
92 Branch
Tracking Status
firefox92 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

Details

Attachments

(1 file)

The test helper assertPausedLocation has the following jsdoc:

/**
 * Assert that the debugger is paused at the correct location.
 *
 * @memberof mochitest/asserts
 * @param {Object} dbg
 * @param {String} source
 * @param {Number} line
 * @static
 */

However, it only accepts a single dbg parameter, source & line are not used/supported.
We should update the JSDoc and fix existing callsites passing 2nd & 3rd arguments to this method. Instead assertPausedAtSourceAndLine can be used. Or we can merge the two methods.

Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/30c583a13c33 [devtools] Fix incorrect usage of assertPausedLocation in Debugger mochitests r=nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: