1721733 - browser_target_list_service_workers_navigation.js fails with server side target switching enabled

Status: RESOLVED DUPLICATE of bug 1691585

(DevTools :: Framework, defect)

Description

[Alexandre Poirot [:ochameau]]

This test fails because the TargetCommand destroy all the targets on top level target switching:
https://searchfox.org/mozilla-central/rev/77256682a1fe0e73c5ad34c593b1ecacfefdf4e1/devtools/shared/commands/target/target-command.js#168-174

Unfortunately, fixing that isn't enough to make the test pass.
The SW target seems to not be destroyed when we unregister it...

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1721733 - [devtools] Partially fix browser_target_list_service_workers_navigation.js

On target switch we destroy all targets currently registered in TargetCommand,
this includes Service Worker targets.
Whereas we expect them to be kept across target switch, and only
destroyed when the LegacyListener tells us they are destroyed.

Fixing this, seem to make the test fail later, or there is yet something else.
The SW target isn't destroyed when we unregister the .org SW.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

the test run fine after I apply the patch I pushed for Bug 1691585 (https://phabricator.services.mozilla.com/D120710), so I'm going to close this as a duplicate