1721804 - Double separator in Calendar's `File > New >` submenu

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect, P5)

Description

[Thomas D. (:thomas8)]

Attachment: Screenshot 1: double separator in `File > New >` submenu

STR

1. Start from Calendar or Tasks tab
2. File > New >

Actual (see screenshot)

• between Task... and Get a new mail account... there's a double menu separator with nothing in between

Expected

• show single separator only
• or if there's a missing item between the separators (?), show that

Comment 1

[Richard Marti (:Paenglab)]

In mail tab there are the menuitems "Folder..." and "Saved Search...". So it seems a separator needs to be hidden too with the other two menuitems.

Comment 2

[Thomas D. (:thomas8)]

(In reply to Richard Marti (:Paenglab) from comment #1)

In mail tab there are the menuitems "Folder..." and "Saved Search...". So it seems a separator needs to be hidden too with the other two menuitems.

I recall vaguely that we used to have a function which is supposed to eliminate any double separators.

Comment 3

[Richard Marti (:Paenglab)]

I have a patch that hides the separator.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1721804-hide-newAccountPopupMenuSeparator.patch

Hide newAccountPopupMenuSeparator together with menu_newFolder and menu_newVirtualFolder.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5147c6bee3dc
Hide newAccountPopupMenuSeparator together with menu_newFolder and menu_newVirtualFolder. r=darktrojan

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 9232626 [details] [diff] [review]
1721804-hide-newAccountPopupMenuSeparator.patch

[Approval Request Comment]
User impact if declined: weird double separator in File > New when not a mail tab is active
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9232626 [details] [diff] [review]
1721804-hide-newAccountPopupMenuSeparator.patch

[Triage Comment]
Approved for beta

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 91.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/c241985e725a

Comment 9

[WaltS48 [:walts48]]

Using Thunderbird 91.0b4 on Windows 10.

Comment 10

[Thomas D. (:thomas8)]

Perfect! Thank you, Richard!