1721816 - [Proton] New Bookmarks Bar Folder Menu Font is too tall

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Mehmet]

Attachment: Compare.png

Nightly 92.0a1 (2021-07-22) (64-Bit)
macOS 10.15.7

Steps to reproduce:

1.) Compare Bookmarks Bar Folder Menu Font with Hamburger Menu Font (or other Doorhanger Menu Font)

Actual: The font in the new Bookmarks Bar Folder Menu looks too tall.

Expected: Smaller font size like in the Hamburger Menu.

A zoomed screenshot is attached. Please take a closer look at the letter "N" in both menus. There you can see the difference.

Thanks for checking.

Comment 1

[Mehmet]

Hi, maybe interesting: I can't reproduce this issue on a MacBookAir Retina-Display with installed macOS 11.4.

I am seeing this issue on an iMac Non-Retina with installed macOS 10.15.7.

So, either this is Non-Retina issue or a MacOS version issue? :(

Comment 2

[:Gijs (he/him)]

(In reply to Mehmet from comment #1)

Hi, maybe interesting: I can't reproduce this issue on a MacBookAir Retina-Display with installed macOS 11.4.

I am seeing this issue on an iMac Non-Retina with installed macOS 10.15.7.

So, either this is Retina/Non-Retina issue or a MacOS version issue? :(

I couldn't reproduce on 11.4 with a retina display, which explains my confusion. I don't have a non-retina mac to hand.

Markus, do you know off-hand what would cause the discrepancy here?

Comment 3

[Markus Stange [:mstange]]

I cannot reproduce this on non-Retina on macOS 12.0 Beta (21A5284e). So it might be an OS version issue.
Comparing to Mehmet's screenshot, both my bookmark folders and my menu panel use the smaller font, i.e. text rendering matches the text on the right ("Neues Fenster").

Comment 4

[Markus Stange [:mstange]]

Oh, but the browser toolbox shows that the CSS is indeed different for the two! The hamburg menu uses font: Menu, as Gijs said, but the bookmarks folder uses font: -moz-pull-down-menu!
https://searchfox.org/mozilla-central/rev/523ac2e17550f1f1da16aacdc6ac647af8b35508/toolkit/themes/osx/global/menu.css#114

So maybe for some reason, -moz-pull-down-menu is larger than Menu on macOS 10.15.

Comment 5

[:Gijs (he/him)]

Attachment: Bug 1721816 - force font: Menu on bookmarks toolbar menubutton menus as well as folders on the bookmarks toolbar to avoid -moz-pull-down-menu from menu.css on macOS making a difference on some macOS versions, r?emalysz

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9caeb031968e
force font: Menu on bookmarks toolbar menubutton menus as well as folders on the bookmarks toolbar to avoid -moz-pull-down-menu from menu.css on macOS making a difference on some macOS versions, r=emalysz

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9caeb031968e

Comment 8

[Mehmet]

Thanks. I can confirm this is fixed in Nightly 92.0a1 (2021-07-27) (64-Bit) on macOS 10.15.7.

Comment 9

[Timea Zsoldos [:tzsoldos], Desktop QA]

I can confirm this issue is fixed on Fx 95.0b4, testing on macOS 10.15 and didn't see any font rendering issue.