1721823 - browser_aboutdebugging_devtoolstoolbox_navigate_back_forward.js fails with server side targets

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[Alexandre Poirot [:ochameau]]

This fails because this test does many navigations and now we get target switching from the server.

Target switching is an issue because about:debugging doesn't support target switching.
If the first top level target is destroyed, we would close the toolbox.

So, we should either:

• make about:debugging support top level target switching and remove the few checks that explicitely disallow this.
  I don't think that's complex, there shouldn't be any particular challenge ? It should mostly about removing the various checks enabling this only for local tab and the code to destroy the toolbox on target destroy.

• Stop using the preference in the server codebase and instead receive this setting from the client, so that server side target switching is only enabled by local tab descriptor. This may help use better control where server side targets are enabled, in case it has any impact on other toolboxes?

The second options looks slightly more simple and may be a good patch to have independently of this limitation in about:debugging.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1721823 - [devtools] Make isServerTargetSwitchingEnabled be a runtime flag from server standpoint.

This helps enabling server targets only for local tabs descriptors
and so prevents enabling them for about:debugging toolboxes.
They are always using remote tabs descriptors and do not support target switching yet.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0182a908c704
[devtools] Make isServerTargetSwitchingEnabled be a runtime flag from server standpoint. r=jdescottes,devtools-backward-compat-reviewers

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/0182a908c704