1721858 - Enable WebSocket connection partitioning if first party isolation is enabled

Status: RESOLVED FIXED

(Core :: Networking: WebSockets, enhancement, P2)

Description

[Emma Zühlcke [:emz]]

The Websocket connection partitioning which was added in Bug 1713748 separates the pending connection queue by origin attributes. That means first party isolation can also benefit from it and we should enable it when first party isolation is enabled.

We can extend this pref check to include the first party isolation pref:
https://searchfox.org/mozilla-central/rev/352b525ab841278cd9b3098343f655ef85933544/netwerk/protocol/websocket/WebSocketChannel.cpp#490

bool isPartitioned =
          ( StaticPrefs::privacy_partition_network_state() || StaticPrefs::privacy_firstparty_isolate() ) &&
          StaticPrefs::privacy_partition_network_state_ws_connection_queue()

Keeping privacy_partition_network_state_ws_connection_queue separate is probably a good idea so the feature can still be turned off independently.

Comment 1

[Emma Zühlcke [:emz]]

Attachment: Bug 1721858 - Enable WebSocket connection partitioning if first party isolation is enabled. r=timhuang!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8dc169b04bbc
Enable WebSocket connection partitioning if first party isolation is enabled. r=nhnt11

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/8dc169b04bbc