1721867 - Remove the concept of a decryptor id from the GMP

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, task, P1)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Bug 1306314 introduced the idea of a decryptor id. It looks like this was done to handle issues with Widevine persistent storage.

Over time the code has changed such that we no longer use the decryptor id (looks like bug 1392506 and friends did at least some of this). However, decryptor id is still plumbed. We should remove it.

Further details:

• The current source of decryptor ids appears to be in GMPVideoDecoder code, which always returns 0. I.e. we don't seem to generate different ids, I assume because we don't use them anywhere anymore.
• Following the current plumbing to its end gets me to ChromiumCDMAdapter::GMPGetAPI, which just logs the id. I.e. it's not used in a meaningful way.

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1721867 - Remove the concept of decryptor id from the GMP. r?alwu,jolin

Decryptor id is no longer used anywhere functional, but we still have code
referencing and plumbing values around. This patch removes all the remaining
usage I can find in Gecko.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/762c7aeeb496
Remove the concept of decryptor id from the GMP. r=alwu,jolin

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/762c7aeeb496