Open Bug 1721899 Opened 2 months ago Updated 17 days ago

test_cloneElementVisually_no_suspend.html fails due to broken promiseWaitForCondition check

Categories

(Core :: Audio/Video, defect, P2)

defect

Tracking

()

REOPENED

People

(Reporter: nika, Assigned: mconley)

References

(Depends on 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Before the changes in bug 1721898, SimpleTest.promiseWaitForCondition would not handle async conditions properly, and would treat them as sync conditions. As the promise object returned from calling an async function is truthy, all async conditions were considered successful as soon as they are called.

After the changes in bug 1721898, when running test_cloneElementVisually_no_suspend.html, the waitForShutdownDecoder call (https://searchfox.org/mozilla-central/rev/2022d34edd5817948b27f093cd203ae6adb18a25/dom/media/test/cloneElementVisually_helpers.js#200-203) now fails due to actually being run, and is being disabled.

Depends on: 1721898

Mike, would you mind taking a look at this? Thanks a lot!

Flags: needinfo?(mconley)
Assignee: nobody → mconley
Flags: needinfo?(mconley)

The waitForShutdownDecoder test helper function was introduced in bug 1521964,
but the interface for the function that it was calling (mozDebugReaderData)
changed in bug 1542674. Due to the way the promiseWaitForCondition used to
work before bug 1721898, the sudden breakage of that interface was silently
ignored and this helper function stopped working without us knowing.

After bug 1721898 landed, this breakage suddenly became visible. This patch
updates waitForShutdownDecoder to use the machine-readable debug data
structure that was introduced in bug 1542674. It's still a hacky way of
determining when a video decoder has shut down, but I'm not aware of
any other way of doing that, and this is just for a test.

Triaging. FWIW :pehrsons is on PTO and will be back next week.

Severity: -- → S3
Priority: -- → P2
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e96abe35f3b2
Update waitForShutdownDecoder helper function to use mozRequestDebugInfo. r=bryce
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
Backout by csabou@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/d66e0aca4012
Backed out changeset e96abe35f3b2 for causing bug 1724106.
Attachment #9234852 - Attachment is obsolete: true

Can someone cc me on bug 1724106 so I can get more context?

Flags: needinfo?(mconley)

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:mconley, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(mconley)
Flags: needinfo?(bvandyk)
Depends on: 1724106
No longer regressions: 1724106

I think this should be unblocked following bug 1724106 landing. I'll attempt to reland this.

Flags: needinfo?(mconley)
Flags: needinfo?(bvandyk)
Pushed by bvandyk@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3c0107dc649d
Update waitForShutdownDecoder helper function to use mozRequestDebugInfo. r=bryce

Looks like we still have some issues. I'll request backout and take another run at fixing up the debug helpers this relies on.

Backed out changeset 3c0107dc649d (bug 1721899) as requested by bryce.
Backout link: https://hg.mozilla.org/integration/autoland/rev/bb768a5f6a9681fb643d8e2177b0707f652a502d

You need to log in before you can comment on or make changes to this bug.