test_cloneElementVisually_no_suspend.html fails due to broken promiseWaitForCondition check
Categories
(Core :: Audio/Video, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox100 | --- | fixed |
People
(Reporter: nika, Assigned: mconley)
References
Details
Attachments
(1 file, 1 obsolete file)
Before the changes in bug 1721898, SimpleTest.promiseWaitForCondition
would not handle async conditions properly, and would treat them as sync conditions. As the promise object returned from calling an async function is truthy, all async conditions were considered successful as soon as they are called.
After the changes in bug 1721898, when running test_cloneElementVisually_no_suspend.html
, the waitForShutdownDecoder
call (https://searchfox.org/mozilla-central/rev/2022d34edd5817948b27f093cd203ae6adb18a25/dom/media/test/cloneElementVisually_helpers.js#200-203) now fails due to actually being run, and is being disabled.
Comment 1•3 years ago
|
||
Mike, would you mind taking a look at this? Thanks a lot!
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 2•3 years ago
|
||
The waitForShutdownDecoder test helper function was introduced in bug 1521964,
but the interface for the function that it was calling (mozDebugReaderData)
changed in bug 1542674. Due to the way the promiseWaitForCondition used to
work before bug 1721898, the sudden breakage of that interface was silently
ignored and this helper function stopped working without us knowing.
After bug 1721898 landed, this breakage suddenly became visible. This patch
updates waitForShutdownDecoder to use the machine-readable debug data
structure that was introduced in bug 1542674. It's still a hacky way of
determining when a video decoder has shut down, but I'm not aware of
any other way of doing that, and this is just for a test.
Triaging. FWIW :pehrsons is on PTO and will be back next week.
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e96abe35f3b2 Update waitForShutdownDecoder helper function to use mozRequestDebugInfo. r=bryce
Comment 5•3 years ago
|
||
bugherder |
Comment 6•3 years ago
|
||
Backed out for causing Bug 1724106.
Failure log: https://treeherder.mozilla.org/logviewer?job_id=347443082&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/42e5f67d2e5e1e145c6727d520229acb10657334
Backout by csabou@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/d66e0aca4012 Backed out changeset e96abe35f3b2 for causing bug 1724106.
Comment 8•3 years ago
|
||
Updated•3 years ago
|
Assignee | ||
Comment 9•3 years ago
|
||
Can someone cc me on bug 1724106 so I can get more context?
Comment 10•3 years ago
|
||
CCed Mike on the bug.
Comment 11•3 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:mconley, could you have a look please?
For more information, please visit auto_nag documentation.
I think this should be unblocked following bug 1724106 landing. I'll attempt to reland this.
Comment 13•3 years ago
|
||
Pushed by bvandyk@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3c0107dc649d Update waitForShutdownDecoder helper function to use mozRequestDebugInfo. r=bryce
Looks like we still have some issues. I'll request backout and take another run at fixing up the debug helpers this relies on.
Comment 15•3 years ago
•
|
||
Backed out changeset 3c0107dc649d (bug 1721899) as requested by bryce.
Backout link: https://hg.mozilla.org/integration/autoland/rev/bb768a5f6a9681fb643d8e2177b0707f652a502d
Bug 1724106 has landed, going to give it a day to bake and then will come back and try to land this.
Comment 17•2 years ago
|
||
Pushed by bvandyk@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/77d5a3a067e4 Update waitForShutdownDecoder helper function to use mozRequestDebugInfo. r=bryce
Comment 18•2 years ago
|
||
bugherder |
Description
•