Closed
Bug 1721911
Opened 3 years ago
Closed 3 years ago
browser_accessibility_fission_switch_target.js fails intermitently with server targets
Categories
(DevTools :: Accessibility Tools, defect)
DevTools
Accessibility Tools
Tracking
(Fission Milestone:MVP, firefox92 fixed)
Tracking | Status | |
---|---|---|
firefox92 | --- | fixed |
People
(Reporter: ochameau, Assigned: nchevobbe)
References
Details
(Whiteboard: dt-fission-m3-mvp)
Attachments
(1 file)
This test fails intermitently. I reproduce locally with --run-until-failure.
It looks like the panel fails to emit the reloaded
event.
From what I can see, in the following code, during a navigation:
https://searchfox.org/mozilla-central/rev/2022d34edd5817948b27f093cd203ae6adb18a25/devtools/client/accessibility/panel.js#185-189
const onUpdated = this.panelWin.once(EVENTS.INITIALIZED);
this.refresh();
await onUpdated; // <<< === we are stuck here. No INITIALIZED event.
this.emit("reloaded");
I have not dug this deeper.
Updated•3 years ago
|
Severity: -- → S4
Assignee | ||
Comment 1•3 years ago
|
||
Updated•3 years ago
|
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•3 years ago
|
||
the issue was that the initialization code was running while the getFront("accessibility")
Promise in onTargetAvailable
wasn't settled, which would cause the getChildren
method to return an empty array, and later down the road, to the EVENTS.INITIALIZED
event to not be emitted.
Updated•3 years ago
|
Fission Milestone: --- → MVP
Whiteboard: dt-fission-m3-triage → dt-fission-m3-mvp
Updated•3 years ago
|
Attachment #9233063 -
Attachment description: Bug 1721911 - [devtools] Wait for accessibility front to be available on target switch. r=ochameau. → Bug 1721911 - [devtools] Fix a11y inspector with server side target switch.r=ochameau.
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d565380e0bba
[devtools] Fix a11y inspector with server side target switch.r=ochameau.
Comment 4•3 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox92:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•