1721946 - vCardToAbCard incorrectly handles multiple values in name components

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Geoff Lankow (:darktrojan)]

From RFC6350:

The text components are separated by the SEMICOLON character (U+003B). Individual text components can include multiple text values separated by the COMMA character (U+002C).

The parser correctly reads multiple values separated by a comma into an array of values, but we need a string.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1721946 - Read multiple name values correctly when converting from VCard. r=rnons

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5e78571e7056
Read multiple name values correctly when converting from VCard. r=rnons

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9232766 [details]
Bug 1721946 - Read multiple name values correctly when converting from VCard. r=rnons

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: faulty parsing of vCards, very minor, very unlikely
Testing completed (on c-c, etc.): landed last week
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9232766 [details]
Bug 1721946 - Read multiple name values correctly when converting from VCard. r=rnons

[Triage Comment]
Approved for beta

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 91.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/c6a3d6f5c184