1721952 - RTL Text Pasted into Wordpress Visual Editor Renders LTR

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[brian]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

1. Edit a new post or page in the Wordpress visual editor (Gutenberg)
2. Add a new paragraph block in the post or page
3. Paste Hebrew text from https://blueletterbible.org into the paragraph block

Actual results:

Pasted Hebrew text displays backwards (LTR)

NOTE - When the post or page is previewed or published the Hebrew text renders correctly.

Also, the Hebrew rendering can be corrected by entering the HTML editing mode of the Gutenberg editor and putting explicit <rtl></rtl> tags around the Hebrew text. What is REALLY weird is that this corrects the RTL display of not only that particular block of Hebrew text, but also for every other block of Hebrew text on the page or post.

Expected results:

Hebrew text should have displayed correctly (RTL)

Comment 1

[brian]

I tested with MS Edge, and the Gutenberg visual editor displays pasted RTL text correctly.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::DOM: Editor' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

I can reproduce this and I guess bidi is not enabled properly. I tried adding direction:rtl at a random element outside of the editor and doing so suddenly fixed the issue.

Emilio, do you see what's happening here?

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

Copy this for your convenience: בְּרֵאשִׁית בָּרָא אֱלֹהִים אֵת הַשָּׁמַיִם וְאֵת הָאָֽרֶץ׃

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Self-descriptive / commented reduced test-case.

That's exactly right. We stop properly updating CharacterData::mText.mState.mIsBidi once bidi is enabled in a document, but then if it gets adopted into a document which is not bidi-enabled we fail to enable bidi.

direction: rtl "fixes" it because it force-enables bidi here.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Self-descriptive / commented reduced test-case.

Now without it being cropped, whoops

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1721952 - Don't let nsTextFragment::IsBidi get out of sync even if the document has already enabled bidi. r=smaug

It's not a sound optimization in presence of adoption.

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/30172 for changes under testing/web-platform/tests

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/1daed8d82b9a

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot